Closed Bug 910506 Opened 6 years ago Closed 6 years ago

update harfbuzz to latest code from upstream

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jtd, Assigned: jfkthame)

References

Details

Attachments

(2 files)

Some of the code for iterating over coverage data is faulty and will result in infinite loops in some cases.  See bug 903475.  These appear to be fixed by recent updates

July 30
commit 48382e2f41499a91181bea0acc5792989d2485bb
Assignee: nobody → jfkthame
This is because the semantics of the get_glyph callback was changed (see upstream commit 79d1007a501fd63c0ba4d51038c513e6b8b94740 on June 13th) to allow for fonts that handle variation selectors using GSUB rules rather than a format-14 cmap table. Relevant to some Mongolian fonts (not that we really support those yet).
Attachment #803543 - Flags: review?(jdaggett)
Attachment #803543 - Flags: review?(jdaggett) → review+
Attachment #803542 - Flags: review?(jdaggett) → review+
Refreshed patch to pick up harfbuzz release 0.9.21 plus a couple of subsequent fixes; we're now at 078de49ca10285f6cd1452abd40f831a17af5d1a from upstream.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a9382595fce
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff34f480df07
Target Milestone: --- → mozilla27
And backed out again, in https://hg.mozilla.org/integration/mozilla-inbound/rev/ed12f73dbeac. This caused variation-selector-unsupported-1.html to fail because the unsupported variation selector remains in the glyph stream, and appears as a .notdef box.

Need to think about where best to fix this (within harfbuzz, or in our gfx code)...
Fixed upstream by commit 3d2c4f0c2ff8fab4262988aad65b170e5b479b20; re-landed the patches here, updated to include that change. (See discussion of hb_ot_hide_default_ignorables on the HB mailing list.)

https://hg.mozilla.org/integration/mozilla-inbound/rev/e087b5e21077
https://hg.mozilla.org/mozilla-central/rev/e087b5e21077
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1278614
You need to log in before you can comment on or make changes to this bug.