Closed
Bug 910588
Opened 11 years ago
Closed 11 years ago
log a parse error for <table><input></table>
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: sideshowbarker, Unassigned)
Details
Attachments
(3 files)
|
947 bytes,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
2.54 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
2.16 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Per http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-intable the markup case <table><input></table> -- a start tag whose tag name is "input" in the "in table" insertion mode -- is defined as a (non-fatal) parse error. But the current code doesn't treat it as a parse error.
|
Reporter | |
Updated•11 years ago
|
Summary: log parse error for <table><input></table> → log a parse error for <table><input></table>
|
|
Reporter | |
Comment 1•11 years ago
|
||
https://bitbucket.org/sideshowbarker/htmlparser-fork/commits/aecbe13194bfdedc0d6b1f764b60e1604b68e384
Attachment #797796 -
Flags: review?(hsivonen)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 797796 [details] [diff] [review] patch Realized this patch doesn't work for the input@type=hidden case.
Attachment #797796 -
Attachment is obsolete: true
Attachment #797796 -
Flags: review?(hsivonen)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 797796 [details] [diff] [review] patch Actually I did have it right the first time: The spec requires a parse error here regardless, including for the input@type=hidden case (which doesn't get foster-parented). https://bitbucket.org/sideshowbarker/htmlparser-fork/commits/aecbe13194bfdedc0d6b1f764b60e1604b68e384
Attachment #797796 -
Attachment is obsolete: false
Attachment #797796 -
Attachment is patch: true
Attachment #797796 -
Flags: review?(hsivonen)
|
||
Updated•11 years ago
|
Attachment #797796 -
Flags: review?(hsivonen) → review+
|
|
||
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 4•11 years ago
|
||
Landed. Thanks. Leaving open for the corresponding generated Gecko patch (which I intend to generate later today; just realized that this actually affects View Source in Gecko). https://hg.mozilla.org/projects/htmlparser/rev/10d31b60640f
|
|
||
Comment 5•11 years ago
|
||
Attachment #802949 -
Flags: review+
|
|
||
Comment 6•11 years ago
|
||
Attachment #802950 -
Flags: review?(bugs)
|
||
Comment 7•11 years ago
|
||
Comment on attachment 802950 [details] [diff] [review] Reftest rs=me
Attachment #802950 -
Flags: review?(bugs) → review+
|
|
||
Comment 8•11 years ago
|
||
Thanks. Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d00ebb532e5 https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a21f0203aa
|
||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2d00ebb532e5 https://hg.mozilla.org/mozilla-central/rev/b4a21f0203aa
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•