910634 - disabled <input> should not popup a dialog

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[wbsecg1]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.57 Safari/537.36

Steps to reproduce:

click a disabled <input> element, for example

    <input type="date" disabled="true">


Actual results:

popup a date dialog


Expected results:

nothing happens

Comment 1

[wbsecg1]

https://github.com/mozilla/mozilla-central/pull/18/files

Comment 2

[Aaron Train [:aaronmt]]

Thanks for the patch. We use Mercurial and attach patches to bugs for review. Can you follow this guide?

https://developer.mozilla.org/en-US/docs/Installing_Mercurial
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ

Comment 3

[wbsecg1]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Thanks for the patch. We use Mercurial and attach patches to bugs for
> review. Can you follow this guide?
> 
> https://developer.mozilla.org/en-US/docs/Installing_Mercurial
> https://developer.mozilla.org/en-US/docs/Mercurial_FAQ

I will try

Comment 5

[Aaron Train [:aaronmt]]

As per bug 914573

> Happens the same with the readonly attribute. Also when the input is disabled AND readonly.

Comment 6

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: 910634.patch

Hi wesj,

I faced same problem at 1130614.
and I created patch for this problem.

Could you review this my patch?

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8569766 [details] [diff] [review]
910634.patch

Review of attachment 8569766 [details] [diff] [review]:
-----------------------------------------------------------------

Nice and pretty! Thanks

Comment 8

[:Margaret Leibovic]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f0fa4210f27

Since wesj already gave this an r+, once this is green, we can add the "checkin-needed" keyword to this bug, and a sheriff will check it in for you.

Comment 9

[Mantaroh Yoshinaga[:mantaroh]]

Hi Margaret,

Thank you for run to Try.
Could you add a "checkin-needed" keyword to this bug?

Comment 10

[:Margaret Leibovic]

(In reply to mantaroh from comment #9)
> Hi Margaret,
> 
> Thank you for run to Try.
> Could you add a "checkin-needed" keyword to this bug?

Sure! You can also do this yourself in the future, as long as there is a green try run.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/466d2f2a7b7e

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/466d2f2a7b7e