910647 - private-browsing-supported/test-sidebar.testSidebarIsOpenInNewPrivateWindow is failing

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Matteo Ferretti [:zer0] [:matteo]]

resource://private-browsing-mode-test-at-jetpack/private-browsing-supported/lib/test-sidebar.js, line 70: sidebarEle.contentDocument.getElementById(...) is null

In accordance with Erik I removed temporary the test in order to land bug 908162 and fixes bug 906690.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1237

Pointer to Github pull-request

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 802028 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1237

r+, with the comments addressed.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 802028 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1237

Responded to comments, looking for feedback.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 802028 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1237

feedback given in the PR

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2db62ec0aaf85f4ac6cb349ad8cd6e4537e2cbcc
Bug 910647 sidebars no longer migrate across windows with different private states due to bug 885054

https://github.com/mozilla/addon-sdk/commit/6062af58392f990d843d74c60ad02675e39661ec
Merge pull request #1237 from erikvold/910647

Bug 910647 sidebars no longer migrate across windows with different private states due to bug 885054 r=@ZER0

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This looks like it created a new intermittent failure on at least Linux:
https://tbpl.mozilla.org/php/getParsedLog.php?id=28632510&tree=Jetpack

We'll either need to get that fixed or revert the pull request before the next uplift can happen.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Erik reverted this in https://github.com/mozilla/addon-sdk/commit/fb09a898b46da1507fa4339eba5d0cf8b8f4caf4

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562