910648 - [B2G][Helix][Setting][shijinde]Enable USB Storage should have one

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; aff-kingsoft-ciba; .NET4.0C; .NET4.0E; Zune 4.7; Tablet PC 2.0)

Steps to reproduce:

1、in setting main screen, there is one item about Enable USB Storage
2、in media storage screen, there is another item about Enable USB Storage


Actual results:

1、in setting main screen, there is one item about Enable USB Storage
2、in media storage screen, there is another item about Enable USB Storage


Expected results:

you need remove the item in media storage screen.

Comment 1

[Evelyn Hung]

Per design. ni UX team.

Comment 2

[Stephany Wilkes]

In a rare needinfo trio, I am flagging Sri (as to where this might fit in the engineering backlog for Media); Rob (who does UX for Media); AND Neo, as Settings falls under his purview - and because it seems there may need to be coordination between Media Storage and Settings.

Comment 3

[lecky]

Hi, what is the result about this problem? 

if you can't resolve in v1.1, please give me the information in the bug.

or if you can resolve in v1.1, also please give me the plan.

Thanks

Comment 4

[Dave Hylands [:dhylands]]

So, just to clarify, there is a setting called "Enable USB Storage" both in the main settings and inside the Media Storage panel, which both control the same option.

The "Share using USB" option is a per-volume control for USB storage. I would argue, that if there is only a single volume, then the "Share using USB" option shouyld disappear, and the settings app should set the single volume sharing option to reflect the "Enable USB Storage" setting.

I figured it was worth clarifying that this bug is just talking about there being two master controls.

Comment 5

[Sri Kasetti]

Adding Bruce as this is part of settings app.

Comment 6

[Bruce Huang [:bhuang] (inactive)]

This will not be in 1.1, investigating for 1.2/1.3 depending on if we can get to a UX consensus.

Comment 7

[Preeti Raghunath(:Preeti)]

Moving it to 1.3. UX if you do feel this is needed in 1.2 please re-nom.

Comment 8

[Neo Hsieh [:neo]]

Joe just told me that is in 1.3.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

can decide in v1.3? triages

Comment 10

[Beatriz Rodríguez [:brg]]

Agree with comment 6 and comment 9.

Comment 11

[Evelyn Hung]

Do we have a UX decision here? If we are going to remove one, I (dev) would like to know which one..

Comment 12

[Stephany Wilkes]

We have a UX decision: Please remove the Enable USB storage setting from the media storage page. No need for the redundancy.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: -'ing, feel free to submit patch.

Comment 14

[Ram Dayal Vaishnav [:ram]]

I would like to work on this. can I get this bug assigned?

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thank you. Please look at

https://github.com/mozilla-b2g/gaia/blob/master/README.md
https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking

and particularly,

https://developer.mozilla.org/en-US/Firefox_OS/Platform/Gaia/Hacking#Submitting_a_patch

on how to submit a patch to Gaia. Thank you!

Comment 16

[Ram Dayal Vaishnav [:ram]]

I am working on file "\gaia-master\apps\settings\elements\media_storage.html", am I one the right track?

Comment 17

[Ram Dayal Vaishnav [:ram]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15166

Comment 18

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8357907 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15166

Ram, thanks for your contribution!

We also need to remove the code related to the removed UI. Please check settings/js/media_storage.js. Let me know if you encounter any problem.

Comment 19

[Ram Dayal Vaishnav [:ram]]

Following Pull Request contains changes in .js file only. Kindly let me know if these changes are correct, I will merge both RP's then. (sorry for unablility to create single PR for this)

https://github.com/mozilla-b2g/gaia/pull/15292

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

We can only merge the code with one pull request in one bug. You can do the following to update your existing pull request.

1. Do some change on your local branch and commit.
2. $ git push <your_remote> <branch_name> // in your case it might be $ git push origin patch-7

Comment 21

[Ram Dayal Vaishnav [:ram]]

Attachment: Patch - https://github.com/mozilla-b2g/gaia/pull/16108

Comment 22

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8373000 [details] [review]
Patch - https://github.com/mozilla-b2g/gaia/pull/16108

Thanks for the patch! 

We still need the checkbox for each volume but in this patch all of them were removed. Please only remove the logic related to the removed dom elements, for example:

this.umsEnabledCheckBox = document.getElementById('ums-switch');
this.umsEnabledInfoBlock = document.getElementById('ums-desc');

And the codes that are only associated with this.umsEnabledCheckBox and this.umsEnabledInfoBlock.

Comment 23

[Ram Dayal Vaishnav [:ram]]

I have been able to commit in my branch, but struggling to rebase and squash both commits in this branch. The first commit on this branch is the one which has been rejected above.

Link of the branch - https://github.com/gurumukhi/gaia/compare/patch-10

Comment 24

[Arthur Chen [:arthurcc][inactive after 6/30]]

As this is a simple patch, if you have difficulties rebasing your branch, I would suggest to get the latest code and create a patch again.

Comment 25

[Ram Dayal Vaishnav [:ram]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16108

Comment 26

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for the patch, Ram! As we are focusing on stabilizing the trunk, we are not landing patches that are not DSDS features. I'll review this patch later.

Comment 27

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8380725 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16108

r=me, thanks Ram!

Comment 28

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 9b73892a1e244fde11e3a55cddd7ae85f1fa3984