910713 - [Keyboard][V1.2] The "Global" key isn't hidden if FxOS only had one keyboard layout

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[William Hsu [:whsu]]

* Description:
  This problem happens on v1.2 branch.
  If FxOS only enables one keyboard layout, the "Global" key is still displayed.

* Reproduction steps:
  1. Go to settings app to disable all keyboard layouts.
  1. Launch the contact app
  2. Tap the "Name" field
  4. Look for "Global" key

* Expected result:
  The "Global" key is hidden

* Actual result:
  The Global key shows on text keyboard.

* Reproduction build:(Mozilla-Central)
  + Mercurial-Information
    - Gecko revision="416075f77249"
  + Git-information
    - Gaia revision="94c3dde50cb8da6e9d9ed137bfbf895f8699f8e7"(From Rudy's repository)
  + Gecko version: 26.0a1


Thanks!

Comment 1

[William Hsu [:whsu]]

Attachment: Global Key

Comment 2

[Yuan Xulei [:yxl] (Leave from May 18)]

By design, a keyboard layout will show the global switch button only if mozInputMethod.mgmt.supportsSwitching() returns true.

But mozInputMethod.mgmt.supportsSwitching() didn't fully implemented, it will always return true.

This is the cause of this bug.

To resolve the bug, the InputMethod API of gecko needs a way to get the number of enabled keyboard layouts from gaia.

One possible way to solve it is to send a mozContent event to notify gecko when the keyboard layout number has changed.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 804358 [details] [review]
Patch

r=me.

Jan,

Thank you for your contribution.

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

https://github.com/mozilla-b2g/gaia/commit/3e3365b836d85670f6de24b7beb43eceb93187f7

Comment 6

[William Hsu [:whsu]]

Hi, all,

Thanks for all your help.
I verified it. Now, the global key is hidden when user only enables the one keyboard layout.
Attaching the screenshot.

* Test Build:
 - Gaia:     c6b4cc05b2de6884a652c1c5ab8401216ffa46c1
 - Gecko:    78b3dbc50a8cddea792b6c2870c0bfbe3726335c
 - BuildID   20130917060716
 - Version   26.0a1

Comment 7

[William Hsu [:whsu]]

Attachment: Keyboard Layout

Comment 8

[James Lal [:lightsofapollo]]

Uplifted 3e3365b836d85670f6de24b7beb43eceb93187f7 to:
v1.2 already had this commit