910808 - DeviceStorage uses preferences off the main thread

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

http://hg.mozilla.org/mozilla-central/annotate/21b5af569ca2/dom/devicestorage/nsDeviceStorage.cpp#l768

Preferences can only be safely used from the main thread.  We need to get the value on the main thread and store it somewhere.

Comment 1

[Dave Hylands [:dhylands]]

So I guess the question is who is calling this off the main thread?

Comment 2

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Attachment: Stack

Comment 3

[Dave Hylands [:dhylands]]

Attachment: Remove call to request preference.

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 797578 [details] [diff] [review]
Remove call to request preference.

Added asserts to the places which call GetBool
Removed call to GetBool, since it can be infered from the sDirs->temp which is calculated in InitDirs, which does run on the main thread (there is an assert at the top).

Comment 5

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Comment on attachment 797578 [details] [diff] [review]
Remove call to request preference.

Review of attachment 797578 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +1342,5 @@
>  void
>  nsDOMDeviceStorage::SetRootDirectoryForType(const nsAString& aStorageType,
>                                              const nsAString& aStorageName)
>  {
> +  NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");

MOZ_ASSERT.

@@ +2143,5 @@
>    NS_DECL_CYCLE_COLLECTION_CLASS_AMBIGUOUS(DeviceStorageRequest,
>                                             nsIContentPermissionRequest)
>  
>    NS_IMETHOD Run() {
> +    NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");

MOZ_ASSERT.

@@ +3141,5 @@
>  nsDOMDeviceStorage::EnumerateInternal(const nsAString& aPath,
>                                        const EnumerationParameters& aOptions,
>                                        bool aEditable, ErrorResult& aRv)
>  {
> +  NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");

MOZ_ASSERT.

Comment 6

[Dave Hylands [:dhylands]]

https://tbpl.mozilla.org/?tree=Try&rev=0dc958e5870c

Comment 7

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Looks good.  Can you land this?

Comment 8

[Dave Hylands [:dhylands]]

Oh - thanks for the reminder. I had tried to a few times but the tree was closed.

Comment 9

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/integration/b2g-inbound/rev/667cca919303

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/667cca919303