910875 - Use WEBRTC_LINUX codepaths in audio_device_impl.cc for BSD

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Landry Breuil (:gaston)]

Seems this was an oversight in bug 807492 .. at runtime, audio device just blows:

MEMORY    ; (21:56:35:458 |    0) AUDIO DEVICE:         -1;1816957440; AudioDeviceBuffer created
MEMORY    ; (21:56:35:458 |    0) AUDIO DEVICE:    1    99;1816957440; AudioDeviceModuleImpl created
DEBUGINFO ; (21:56:35:458 |    0) AUDIO DEVICE:    1    99;1816957440; CheckPlatform
CRITICAL  ; (21:56:35:458 |    0) AUDIO DEVICE:    1    99;1816957440; current platform is not supported => this module will self destruct!
MEMORY    ; (21:56:35:458 |    0) AUDIO DEVICE:    1    99;1816957440; ~AudioDeviceModuleImpl destroyed
MEMORY    ; (21:56:35:458 |    0) AUDIO DEVICE:         -1;1816957440; ~AudioDeviceBuffer destroyed

and segfaults later on... indeed, audio_device_impl.cc never got some WEBRTC_BSD love.

Comment 1

[Landry Breuil (:gaston)]

Fwiw, i'm also trying to disentangle globally having --enable-pulseaudio (for everything in mozilla) and using pulseaudio _only_ in webrtc. I dont want to use pulse for firefox itself, we have an sndio cubeb backend.

Comment 2

[Jan Beich]

(In reply to Landry Breuil (:gaston) from comment #1)
> Fwiw, i'm also trying to disentangle globally having --enable-pulseaudio
> (for everything in mozilla) and using pulseaudio _only_ in webrtc. I dont
> want to use pulse for firefox itself, we have an sndio cubeb backend.

Why not write sndio audio_device backend? Or port alsa-lib to OpenBSD?

Comment 3

[Jan Beich]

Attachment: missed

A few ifdefs were forgotten since audio_device diff in bug 807492 and
bug 844818 changed -DWEBRTC_LINUX hack in .gypi to #ifdef WEBRTC_BSD.

Comment 4

[Jan Beich]

Attachment: try #2

dummy change is to fix bug 844818 comment 26 but on BSD

Comment 5

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4141cb0d9cf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d4141cb0d9cf