910882 - URL bar's shadow shouldn't be shown when search suggestions opt-in is shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

As the summary says..

Comment 1

[Sriram Ramasubramanian [:sriram]]

Here is the problem. Though I can hide it when we show suggestions prompt, when the keyboard is dismissed, the LayerView sets the shadow back to true. (why? why?? why??). We use the same browser-toolbar and giving the control to LayerView is a big problem!!

Suggestions:
1. Change the background color of suggestions prompt and leave the shadow to be shown always.
2. Change the LayerView not to overscroll.

Comment 2

[Lucas Rocha (:lucasr)]

Not sure I understand the problem here. Is it just that the bottom line in the toolbar has the same color than the suggestion opt-in UI?

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Making the background a light blue, so that the shadow can still stay, yay!
And the text color is tweaked a little bit, as per Ian's suggestion.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/fx-team/rev/bf0a94794cc5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bf0a94794cc5

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 809351 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Having the URL bar's shadow shown always.
User impact if declined: Awkward blue color with dividers in-between.
Testing completed (on m-c, etc.): Landed long long ago.
Risk to taking this patch (and alternatives if risky): None. Just layout changes.
String or IDL/UUID changes made by this patch: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e145a1d09fac