Closed Bug 910919 Opened 8 years ago Closed 8 years ago

Add a static rooting hazard analysis platform build

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file, 1 obsolete file)

I would like to set up a static rooting analysis builder. This is an analysis that runs on part or all of the firefox tree (and eventually b2g tree as well) to identify and describe a particular pattern that will become unsafe when we implement generational garbage collection (or any other type of collection that moves objects in memory.)
aki - let me know if there's a better reviewer for this. I'm not sure if you work on this stuff.

Note that this patch somewhat deceptively mentions 'spidermonkey' in a couple of places, which isn't entirely appropriate, since the analysis applies to all of the code. But it is for a spidermonkey-specific purpose. I will probably also eventually transition the existing spidermonkey builds to the same mozharness script (with a rather different set of actions.)

My apologies for overloading the platform value with yet another type of builder, but it looks like it's the way things are done in the code currently.
Attachment #797511 - Flags: review?(aki)
Comment on attachment 797511 [details] [diff] [review]
Add a static rooting hazard analysis platform build

>-    'enabled_products': ['firefox', 'mobile'],
>+    'enabled_products': ['firefox', 'mobile', 'hazards'],

Is this product going to have more builds/tests?
I think this is going to create a whole new directory tree on ftp; I'm not sure that's something we want to do lightly.

Seems like this could be part of the firefox product, and the b2g hazards builder could be part of the b2g product.

> for platform in BRANCHES['try']['platforms'].keys():
>-    # Sadly, the rule that mobile builds go to /mobile/
>-    # isn't true for try :(
>-    BRANCHES['try']['platforms'][platform]['stage_product'] = 'firefox'

I think we want to keep this.
Have you tried checking if the stage_product is mobile, and then changing it?

I'm going to minus for now, since it's not clear why we need a new product.
Attachment #797511 - Flags: review?(aki) → review-
Blocks: 834909
(In reply to Aki Sasaki [:aki] from comment #2)
> Comment on attachment 797511 [details] [diff] [review]
> Add a static rooting hazard analysis platform build
> 
> >-    'enabled_products': ['firefox', 'mobile'],
> >+    'enabled_products': ['firefox', 'mobile', 'hazards'],
> 
> Is this product going to have more builds/tests?
> I think this is going to create a whole new directory tree on ftp; I'm not
> sure that's something we want to do lightly.
> 
> Seems like this could be part of the firefox product, and the b2g hazards
> builder could be part of the b2g product.

Fair enough. There'll also be a spidermonkey-specific one, but I can just put that under firefox.

> > for platform in BRANCHES['try']['platforms'].keys():
> >-    # Sadly, the rule that mobile builds go to /mobile/
> >-    # isn't true for try :(
> >-    BRANCHES['try']['platforms'][platform]['stage_product'] = 'firefox'
> 
> I think we want to keep this.
> Have you tried checking if the stage_product is mobile, and then changing it?

I don't need this since I'm not messing with products now, but I still think this should go. philor looked into this, and I'll have to refresh my memory from the logs, but I think the mobile directory is a symlink to the main directory now. So this hasn't done anything in ages, and is just an obstacle to adding products in the future.

Nothing to do with this patch anymore, though.
I nerfed this version -- because this builder isn't all that useful yet, I don't want to burn resources on it. So I made it try-only, and off by default. I figure that'll give me a path to gradually rolling it out. (Just having it on try will be useful to other developers, though I really need to get it uploading the analysis output asap.)

Unfortunately, I didn't see a way to do "try-only" platforms (without using the branch_projects stuff, which won't be necessary once I roll this out for real). So I added an 'extra-platforms' mechanism, which is potentially contentious.
Attachment #800316 - Flags: review?(aki)
Attachment #797511 - Attachment is obsolete: true
Comment on attachment 800316 [details] [diff] [review]
Add a static rooting hazard analysis platform build

Thanks!
Attachment #800316 - Flags: review?(aki) → review+
Depends on: 913760
In production
Blocks: 916677
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.