All users were logged out of Bugzilla on October 13th, 2018

New gralloc textures breaks build on gonk-jb

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: sotaro)

Tracking

unspecified
mozilla26
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
GrallocImages.o
make[1]: Entering directory `/fasthome/mikew/B2G/objdir-gecko/gfx/layers'
/usr/bin/ccache /fasthome/mikew/B2G/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.7/bin/arm-linux-androideabi-g++ -o GrallocImages.o -c  -fvisibility=hidden -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL  -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -DOS_POSIX=1 -DOS_LINUX=1  -I/fasthome/mikew/B2G/gecko/ipc/chromium/src -I/fasthome/mikew/B2G/gecko/ipc/glue -I../../ipc/ipdl/_ipdlheaders  -I/fasthome/mikew/B2G/gecko/content/events/src -I/fasthome/mikew/B2G/frameworks/base/include/media/stagefright -I/fasthome/mikew/B2G/frameworks/base/include/media/stagefright/openmax -I/fasthome/mikew/B2G/frameworks/av/include/media/stagefright -I/fasthome/mikew/B2G/frameworks/native/include/media/openmax  -I/fasthome/mikew/B2G/gecko/gfx/layers -I. -I../../dist/include  -I/fasthome/mikew/B2G/objdir-gecko/dist/include/nspr -I/fasthome/mikew/B2G/objdir-gecko/dist/include/nss      -fPIC -DANDROID -isystem /fasthome/mikew/B2G/bionic/libc/arch-arm/include -isystem /fasthome/mikew/B2G/bionic/libc/include/ -isystem /fasthome/mikew/B2G/bionic/libc/kernel/common -isystem /fasthome/mikew/B2G/bionic/libc/kernel/arch-arm -isystem /fasthome/mikew/B2G/bionic/libm/include -I/fasthome/mikew/B2G/system -I/fasthome/mikew/B2G/system/core/include -isystem /fasthome/mikew/B2G/bionic -I/fasthome/mikew/B2G/hardware/libhardware/include -I/fasthome/mikew/B2G/external/valgrind/fxos-include -I/fasthome/mikew/B2G/frameworks/native/include  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -mandroid -fno-short-enums -fno-exceptions -Wno-psabi -DMOZ_ENABLE_JS_DUMP -include /fasthome/mikew/B2G/gonk-misc/Unicode.h -I/fasthome/mikew/B2G/gecko/build/stlport/stlport -I/fasthome/mikew/B2G/ndk/sources/cxx-stl/system/include -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=softfp -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pipe  -DNDEBUG -DTRIMMED -g -Os -freorder-blocks -fno-reorder-functions -fomit-frame-pointer -I/fasthome/mikew/B2G/objdir-gecko/dist/include/cairo  -I/fasthome/mikew/B2G/objdir-gecko/dist/include/cairo   -DANDROID -isystem /fasthome/mikew/B2G/bionic/libc/arch-arm/include -isystem /fasthome/mikew/B2G/bionic/libc/include/ -isystem /fasthome/mikew/B2G/bionic/libc/kernel/common -isystem /fasthome/mikew/B2G/bionic/libc/kernel/arch-arm -isystem /fasthome/mikew/B2G/bionic/libm/include -I/fasthome/mikew/B2G/system -I/fasthome/mikew/B2G/system/core/include -isystem /fasthome/mikew/B2G/bionic -I/fasthome/mikew/B2G/hardware/libhardware/include -I/fasthome/mikew/B2G/external/valgrind/fxos-include -I/fasthome/mikew/B2G/frameworks/native/include  -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/GrallocImages.o.pp  /fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp
In file included from /fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp:12:0:
../../dist/include/mozilla/layers/GrallocTextureClient.h:81:16: error: 'virtual bool mozilla::layers::GrallocTextureClientOGL::AllocateForYCbCr(mozilla::gfx::IntSize, mozilla::gfx::IntSize)' marked override, but does not override
In file included from ../../dist/include/mozilla/layers/GrallocTextureClient.h:10:0,
                 from /fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp:12:
../../dist/include/mozilla/layers/TextureClient.h:219:16: warning: 'virtual bool mozilla::layers::BufferTextureClient::AllocateForYCbCr(mozilla::gfx::IntSize, mozilla::gfx::IntSize, mozilla::StereoMode)' was hidden [-Woverloaded-virtual]
In file included from /fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp:12:0:
../../dist/include/mozilla/layers/GrallocTextureClient.h:81:16: warning:   by 'virtual bool mozilla::layers::GrallocTextureClientOGL::AllocateForYCbCr(mozilla::gfx::IntSize, mozilla::gfx::IntSize)' [-Woverloaded-virtual]
/fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp:34:1: warning: narrowing conversion of '-1' from 'int' to 'uint32_t {aka unsigned int}' inside { } [-Wnarrowing]
/fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp:34:1: warning: narrowing conversion of '-1' from 'int' to 'uint32_t {aka unsigned int}' inside { } [-Wnarrowing]
/fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp: In member function 'virtual already_AddRefed<gfxASurface> mozilla::layers::GrallocImage::GetAsSurface()':
/fasthome/mikew/B2G/gecko/gfx/layers/GrallocImages.cpp:251:38: warning: pointer of type 'void *' used in arithmetic [-Wpointer-arith]
make[1]: *** [GrallocImages.o] Error 1
make[1]: Leaving directory `/fasthome/mikew/B2G/objdir-gecko/gfx/layers'
make: *** [default] Error 2
(Assignee)

Comment 1

5 years ago
I am going to create a patch soon.
(Assignee)

Comment 2

5 years ago
Sorry, it is already assigned to mwu.
(Reporter)

Comment 3

5 years ago
Created attachment 797542 [details] [diff] [review]
WIP Fix build

Builds but crashes at boot.
(Reporter)

Updated

5 years ago
Assignee: mwu → sotaro.ikeda.g
(Assignee)

Comment 4

5 years ago
Created attachment 797587 [details] [diff] [review]
patch - fix build and  class function override

change from attachment 797542 [details] [diff] [review].
 - changed GrallocTextureSourceOGL::IsValid() to virtual.
 - Change the order of the function as same as TextureSourceOGL.

Confirmed that patch works on my nexus4.
(Assignee)

Comment 5

5 years ago
I feel that since last Saturday, b2g build is generally relatively unstable. So for the confirmation, I got source code from scratch.
(Assignee)

Comment 6

5 years ago
Comment on attachment 797542 [details] [diff] [review]
WIP Fix build

jrmuizel, can you review the patch soon?
Attachment #797542 - Flags: review?(jmuizelaar)
(Assignee)

Updated

5 years ago
Attachment #797542 - Flags: review?(jmuizelaar)
(Assignee)

Comment 7

5 years ago
Comment on attachment 797587 [details] [diff] [review]
patch - fix build and  class function override

Sorry, this patch is for review.
Attachment #797587 - Flags: review?(jmuizelaar)
(Assignee)

Updated

5 years ago
Attachment #797542 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
JB build uses gcc 4.7. ICS build uses gcc 4.6. That difference seems to make the build failure.
(Reporter)

Comment 9

5 years ago
ICS is actually GCC 4.4.x, which makes the situation even worse.
(Assignee)

Comment 10

5 years ago
Comment on attachment 797587 [details] [diff] [review]
patch - fix build and  class function override

Change the review request to nical.
Attachment #797587 - Flags: review?(jmuizelaar) → review?(nical.bugzilla)

Updated

5 years ago
Attachment #797587 - Flags: review?(nical.bugzilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9b9eaadef752
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.