910942 - Don't include unnecessary things in netwerk/.../Dashboard

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Valentin Gosu [:valentin] (he/him)]

Many of the headers included in Dashboard related files are not needed.
Let's forward declare everything we can.

Related: Header dependency graph - https://bug901132.bugzilla.mozilla.org/attachment.cgi?id=785612

Comment 1

[Catalin Iordache]

Attachment: forwardDeclaration.patch

This is what I think we can forward declaration. I'm trying to find more. Hope this is a good start and I'm not doing anything wrong

Comment 2

[Catalin Iordache]

Attachment: forwardDeclarationV2.patch

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 799809 [details] [diff] [review]
forwardDeclarationV2.patch

Review of attachment 799809 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Adding Patrick as a necko peer needs to sign off on this.

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 799809 [details] [diff] [review]
forwardDeclarationV2.patch

Review of attachment 799809 [details] [diff] [review]:
-----------------------------------------------------------------

nice - thank you.

::: netwerk/base/src/Dashboard.cpp
@@ +8,5 @@
>  #include "nsCxPusher.h"
> +#include "nsIDNSService.h"
> +#include "nsSocketTransport2.h"
> +#include "nsIThread.h"
> +#include "nsHttp.h"

please keep these alphabetized - assuming things still compile :)

::: netwerk/base/src/Dashboard.h
@@ +10,5 @@
>  #include "nsITimer.h"
>  #include "nsIDNSListener.h"
> +#include "nsIServiceManager.h"
> +#include "mozilla/net/DashboardTypes.h"
> +#include "mozilla/Mutex.h"

again, order them if you can

Comment 5

[Catalin Iordache]

Attachment: forwardDeclarationV3.patch

Made changes which were specified in review by Patrick.
Ready for checkin

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/238ff32d423b

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/238ff32d423b