910997 - More than 1 Notification doesn't close if an alert is used on Notification onclose

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Caio Lima(:caiolima)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130814063812

Steps to reproduce:

1. Open the "new Notification" from UItest 
2. Open more than 1 Notification
3. Click on "Close all notification"




Actual results:

All the |onclose| functions are called, but only one notification is closed. 


Expected results:

All notification should be closed

Comment 1

[Caio Lima(:caiolima)]

I've tested it with the patch https://bugzilla.mozilla.org/attachment.cgi?id=796122 applied

Comment 2

[Julien Wajsberg [:julienw]]

I'd like to know if that happens in 1.1.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> I'd like to know if that happens in 1.1.

This isn't possible to reproduce on 1.1 - Web Notifications API is enabled on 1.2 or later.

Comment 4

[Julien Wajsberg [:julienw]]

Jason> I mean, with the notifications we have in 1.1.

If we have several notifications from the same app (eg: several missing calls, several sms), does "closing all notification" close them all ?

Comment 5

[Deepa Subramanian]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> If we have several notifications from the same app (eg: several missing
> calls, several sms), does "closing all notification" close them all ?

Hello Julien,

I had 15 notifications from screenshots, missed calls and SMS. Tapping on "Clear All" on the notification bar, clears all the notification. I was not able to repro the bug as per description.

Environmental variables used for testing:
Leo Build ID: 20130830041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/2fb19341d934
Gaia: 577ab5105af418efc8ded00798fd3644b3dac674
Platform Version: 18.1

Comment 6

[Caio Lima(:caiolima)]

The "clear all" from Notification Center doesn't call the "onclose" method of notification. I guess that it's a case of bug https://bugzilla.mozilla.org/show_bug.cgi?id=908978 but to MozNotification.

I guess that the onclose should be called, because the notification is being closed anyway. What do you think?

Comment 7

[Caio Lima(:caiolima)]

Attachment: bug-910997.txt

WIP

It's solving partially the problem, but I don't guess that is the best solution.

As I said in PR, I don't understand why the lines below the |window.dispatch(event)| aren't being executed. 

Could anyone give an idea?

Comment 8

[Reuben Morais [:reuben]]

Comment on attachment 798131 [details] [review]
bug-910997.txt

Sorry I took this long to reply, this request somehow fell through the cracks of my bugmail. I'm really not qualified to review this code, though, so I'm forwarding this to a Gaia System app peer.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 798131 [details] [review]
bug-910997.txt

It looks like you have isolated the error but you didn't provide a proper fix.

Please look for error messages to see if why the function stop executing after that line. Thanks.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Gregor, would it be possible if some thing in shell.js throw and break the code here?

Comment 11

[Caio Lima(:caiolima)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #10)
> Gregor, would it be possible if some thing in shell.js throw and break the
> code here?

I've tested the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=910915 It is working well. Jason, could you confirm it to me? 

Confirming it, this bug is closed then!

Comment 12

[Jason Smith [:jsmith]]

Marking qawanted for a retest with landing of bug 910915.

Comment 13

[Natalya Kot [:nkot]]

have tested on the latest, 9/12, Buri build - the issue does not reproduce, tapping "Clear all" clears off all notifications (tested with 10 notifications: SMS ones, missed calls and calendar reminders)

Build ID: 20130912040201
Gecko: http://hg.mozilla.org/mozilla-central/rev/a98569f21abe
Gaia: 9ffd2899eb91388f7fc1ce6f7a895a6f5f922c05
Platform Version: 26.0a1

Comment 14

[Jason Smith [:jsmith]]

Closing per comment 13