911018 - Call HardwareUtils.init in GeckoView

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: init-hardware

When running a GeckoView-based App, I see this in the log:

This error was fixed by calling HardwareUtils.init(getApplicationContext()); in the Application. We should not require Apps to call this explicitly. I think this could be handled in GeckoView itself.

W/System.err( 2966): java.lang.NullPointerException
W/System.err( 2966): 	at org.mozilla.gecko.util.HardwareUtils.isLargeTablet(HardwareUtils.java:41)
W/System.err( 2966): 	at org.mozilla.gecko.util.HardwareUtils.isTablet(HardwareUtils.java:36)
W/System.err( 2966): 	at org.mozilla.gecko.GeckoAppShell.isTablet(GeckoAppShell.java:2310)
W/System.err( 2966): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
W/System.err( 2966): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
W/System.err( 2966): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:337)
W/System.err( 2966): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:174)

We need to init HardwareUtils

Comment 1

[Brian Nicholson (:bnicholson)]

Comment on attachment 797658 [details] [diff] [review]
init-hardware

Review of attachment 797658 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine for now, but we should probably clean things up so we aren't calling HardwareUtils.init() and Clipboard.init() twice. Maybe these can be turned into singletons so we don't have to worry about init races?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/470293fe677c

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/470293fe677c