Closed Bug 911018 Opened 6 years ago Closed 6 years ago

Call HardwareUtils.init in GeckoView

Categories

(Core Graveyard :: Embedding: GRE Core, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: mfinkle, Unassigned)

References

Details

Attachments

(1 file)

Attached patch init-hardwareSplinter Review
When running a GeckoView-based App, I see this in the log:

This error was fixed by calling HardwareUtils.init(getApplicationContext()); in the Application. We should not require Apps to call this explicitly. I think this could be handled in GeckoView itself.

W/System.err( 2966): java.lang.NullPointerException
W/System.err( 2966): 	at org.mozilla.gecko.util.HardwareUtils.isLargeTablet(HardwareUtils.java:41)
W/System.err( 2966): 	at org.mozilla.gecko.util.HardwareUtils.isTablet(HardwareUtils.java:36)
W/System.err( 2966): 	at org.mozilla.gecko.GeckoAppShell.isTablet(GeckoAppShell.java:2310)
W/System.err( 2966): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
W/System.err( 2966): 	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
W/System.err( 2966): 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:337)
W/System.err( 2966): 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:174)

We need to init HardwareUtils
Attachment #797658 - Flags: review?(bnicholson)
Comment on attachment 797658 [details] [diff] [review]
init-hardware

Review of attachment 797658 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine for now, but we should probably clean things up so we aren't calling HardwareUtils.init() and Clipboard.init() twice. Maybe these can be turned into singletons so we don't have to worry about init races?
Attachment #797658 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/470293fe677c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.