Closed
Bug 911041
Opened 11 years ago
Closed 11 years ago
Map DNT 3 state setting from settings db to Gecko pref
Categories
(Firefox OS Graveyard :: General, defect, P2)
Tracking
(blocking-b2g:koi+, firefox26 fixed)
People
(Reporter: timdream, Assigned: timdream)
References
Details
(Whiteboard: [FT:System-Platform], [koi:P2], [Sprint:4])
Attachments
(1 file, 2 obsolete files)
1.21 KB,
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #900434 +++ We need to hook "privacy.donottrackheader.value" from Gecko pref to settings db.
Assignee | ||
Comment 1•11 years ago
|
||
Fabrice, could you help reviewing this patch? Thanks.
Attachment #797694 -
Flags: review?(fabrice)
Assignee | ||
Comment 2•11 years ago
|
||
Should be |setIntPref()| :-/
Attachment #797694 -
Attachment is obsolete: true
Attachment #797694 -
Flags: review?(fabrice)
Attachment #797695 -
Flags: review?(fabrice)
Updated•11 years ago
|
Whiteboard: [ucid:SystemPlatform11], [FT:System-Platform], [koi:P2], [Sprint: 4] → [FT:System-Platform], [koi:P2], [Sprint:4]
Comment 3•11 years ago
|
||
Comment on attachment 797695 [details] [diff] [review] Patch proposal Review of attachment 797695 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/chrome/content/settings.js @@ +412,5 @@ > > // =================== Privacy ==================== > SettingsListener.observe('privacy.donottrackheader.enabled', false, function(value) { > Services.prefs.setBoolPref('privacy.donottrackheader.enabled', value); > }); Nit: add a blank line
Attachment #797695 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Updated•11 years ago
|
Attachment #797695 -
Attachment is obsolete: true
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/914054e19b53
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/914054e19b53
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-firefox26:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•