Map DNT 3 state setting from settings db to Gecko pref

RESOLVED FIXED

Status

Firefox OS
General
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+, firefox26 fixed)

Details

(Whiteboard: [FT:System-Platform], [koi:P2], [Sprint:4])

Attachments

(1 attachment, 2 obsolete attachments)

+++ This bug was initially created as a clone of Bug #900434 +++

We need to hook "privacy.donottrackheader.value" from Gecko pref to settings db.
Created attachment 797694 [details] [diff] [review]
Patch proposal

Fabrice, could you help reviewing this patch? Thanks.
Attachment #797694 - Flags: review?(fabrice)
Created attachment 797695 [details] [diff] [review]
Patch proposal

Should be |setIntPref()| :-/
Attachment #797694 - Attachment is obsolete: true
Attachment #797694 - Flags: review?(fabrice)
Attachment #797695 - Flags: review?(fabrice)

Updated

4 years ago
Whiteboard: [ucid:SystemPlatform11], [FT:System-Platform], [koi:P2], [Sprint: 4] → [FT:System-Platform], [koi:P2], [Sprint:4]
Comment on attachment 797695 [details] [diff] [review]
Patch proposal

Review of attachment 797695 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/settings.js
@@ +412,5 @@
>  
>  // =================== Privacy ====================
>  SettingsListener.observe('privacy.donottrackheader.enabled', false, function(value) {
>    Services.prefs.setBoolPref('privacy.donottrackheader.enabled', value);
>  });

Nit: add a blank line
Attachment #797695 - Flags: review?(fabrice) → review+
Created attachment 798148 [details] [diff] [review]
Patch for commit
Keywords: checkin-needed
Attachment #797695 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/914054e19b53
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/914054e19b53
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-firefox26: --- → fixed
You need to log in before you can comment on or make changes to this bug.