911041 - Map DNT 3 state setting from settings db to Gecko pref

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P2)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #900434 +++

We need to hook "privacy.donottrackheader.value" from Gecko pref to settings db.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch proposal

Fabrice, could you help reviewing this patch? Thanks.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch proposal

Should be |setIntPref()| :-/

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 797695 [details] [diff] [review]
Patch proposal

Review of attachment 797695 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/settings.js
@@ +412,5 @@
>  
>  // =================== Privacy ====================
>  SettingsListener.observe('privacy.donottrackheader.enabled', false, function(value) {
>    Services.prefs.setBoolPref('privacy.donottrackheader.enabled', value);
>  });

Nit: add a blank line

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch for commit

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/914054e19b53

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/914054e19b53