Closed Bug 911041 Opened 8 years ago Closed 8 years ago

Map DNT 3 state setting from settings db to Gecko pref

Categories

(Firefox OS Graveyard :: General, defect, P2)

x86
macOS
defect

Tracking

(blocking-b2g:koi+, firefox26 fixed)

RESOLVED FIXED
blocking-b2g koi+
Tracking Status
firefox26 --- fixed

People

(Reporter: timdream, Assigned: timdream)

References

Details

(Whiteboard: [FT:System-Platform], [koi:P2], [Sprint:4])

Attachments

(1 file, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #900434 +++

We need to hook "privacy.donottrackheader.value" from Gecko pref to settings db.
Attached patch Patch proposal (obsolete) — Splinter Review
Fabrice, could you help reviewing this patch? Thanks.
Attachment #797694 - Flags: review?(fabrice)
Attached patch Patch proposal (obsolete) — Splinter Review
Should be |setIntPref()| :-/
Attachment #797694 - Attachment is obsolete: true
Attachment #797694 - Flags: review?(fabrice)
Attachment #797695 - Flags: review?(fabrice)
Whiteboard: [ucid:SystemPlatform11], [FT:System-Platform], [koi:P2], [Sprint: 4] → [FT:System-Platform], [koi:P2], [Sprint:4]
Comment on attachment 797695 [details] [diff] [review]
Patch proposal

Review of attachment 797695 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/settings.js
@@ +412,5 @@
>  
>  // =================== Privacy ====================
>  SettingsListener.observe('privacy.donottrackheader.enabled', false, function(value) {
>    Services.prefs.setBoolPref('privacy.donottrackheader.enabled', value);
>  });

Nit: add a blank line
Attachment #797695 - Flags: review?(fabrice) → review+
Attachment #797695 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/914054e19b53
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.