Closed Bug 911071 Opened 11 years ago Closed 11 years ago

Intermittent TEST-UNEXPECTED-FAIL | private-browsing-supported/main.testShowPanelInPrivateWindow | Timed out | the panel is showing - true == false

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
All
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: KWierso, Assigned: evold)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled][leave open])

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1247
358 bytes, text/html
jsantell
: review+
Details 
https://tbpl.mozilla.org/php/getParsedLog.php?id=27213608&tree=Jetpack
https://tbpl.mozilla.org/php/getParsedLog.php?id=27213193&tree=Jetpack
https://tbpl.mozilla.org/php/getParsedLog.php?id=27165686&tree=Jetpack


TEST-START | private-browsing-supported/main.testShowPanelInPrivateWindow
TEST-PASS | private-browsing-supported/main.testShowPanelInPrivateWindow | the panel is not showing [1]
TEST-UNEXPECTED-FAIL | private-browsing-supported/main.testShowPanelInPrivateWindow | the panel is showing - true == false
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/panel/utils.js", line 269, in onPanelStateChange
    events.emit(type, { subject: panel })
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/system/events.js", line 38, in emit
    notifyObservers(subject, type, data);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/system/events.js", line 62, in Observer<.observe
    data: data
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/panel/events.js", line 20, in forward
    emit(channel, "data", { target: subject, type: type, data: data });
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 83, in emit
    for each (let item in emit.lazy.apply(emit.lazy, arguments)) {
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 110, in lazy
    if (~state.indexOf(listener)) yield listener.apply(target, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/utils.js", line 42, in transform/<
    on(input, "data", function(data) f(data, next));
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/utils.js", line 51, in filter/<
    if (predicate(data)) next(data)
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/utils.js", line 36, in next
    function next(data) emit(output, "data", data);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 83, in emit
    for each (let item in emit.lazy.apply(emit.lazy, arguments)) {
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 110, in lazy
    if (~state.indexOf(listener)) yield listener.apply(target, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/utils.js", line 42, in transform/<
    on(input, "data", function(data) f(data, next));
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/utils.js", line 51, in filter/<
    if (predicate(data)) next(data)
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/utils.js", line 36, in next
    function next(data) emit(output, "data", data);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 83, in emit
    for each (let item in emit.lazy.apply(emit.lazy, arguments)) {
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 110, in lazy
    if (~state.indexOf(listener)) yield listener.apply(target, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/panel.js", line 259, in null
    on(shows, "data", function({target}) emit(panelFor(target), "show"));
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 83, in emit
    for each (let item in emit.lazy.apply(emit.lazy, arguments)) {
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 110, in lazy
    if (~state.indexOf(listener)) yield listener.apply(target, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/event/core.js", line 61, in observer
    listener.apply(target, arguments);
  File "resource://private-browsing-mode-test-at-jetpack/private-browsing-supported/lib/test-panel.js", line 70, in testShowPanel/<
    assert.ok(panel.isShowing, 'the panel is showing');
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 102, in ok
    operator: "=="
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/assert.js", line 88, in fail
    this._log.fail(message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 83, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/harness.js", line 525, in testMessage
    this.trace();
TEST-INFO | [JavaScript Error: "Not a number" {file: "resource://gre/modules/PlacesDBUtils.jsm" line: 975}]
TEST-UNEXPECTED-FAIL | private-browsing-supported/main.testShowPanelInPrivateWindow | Timed out
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/timers.js", line 40, in notify
    callback.apply(null, args);
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 423, in tiredOfWaiting
    self.console.testMessage(false, false, self.test.name, "Timed out");
  File "resource://extensions.modules.private-browsing-mode-test-at-jetpack.commonjs.path/sdk/test/harness.js", line 525, in testMessage
    this.trace();
TEST-END | private-browsing-supported/main.testShowPanelInPrivateWindow
Priority: -- → P1
This started failing incredibly frequently on the 9th. Who would be the best to look at this, Dave?
Flags: needinfo?(dtownsend+bugmail)
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/aa510a9559980f5597d1a8849988201040af82a4
Disable private-browsing-supported/test-panel for frequent intermittent failures in bug 911071 on tbpl r=me
Whiteboard: [leave open]
Would you be able to look at this Erik or is there someone else more suited?
Flags: needinfo?(dtownsend+bugmail) → needinfo?(evold)
Whiteboard: [leave open] → [test disabled][leave open]
Assignee: nobody → evold
Attachment #810032 - Flags: review?(jsantell)
It looks like we have two different failures here, one where `panel.isShowing` is false in the `show` event handler and another where `panel.show()` does not cause the `show` event to fire for some reason.

I've only added some additional test information in pull request 1247 for now, it's not clear to me if the hide event is firing after the `show` event emits and it's not clear to me if there is an open non-private window before the test begins.  These changes should answer those questions.
Flags: needinfo?(evold)
Comment on attachment 810032 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1247

Looks good, lets get that debugging in there.
Attachment #810032 - Flags: review?(jsantell) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/5284a4d28d1e9c7d0337cd2d1a8fb7c1748b0733
Bug 911071 - Merely getting more information about failures

https://github.com/mozilla/addon-sdk/commit/f629eb50b259522466e112e7e06e5b6cda77c343
Merge pull request #1247 from erikvold/911071

Bug 911071 - Merely getting more information about failures r=@jsantell
Depends on: 923719
Well some change must've fixed this.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: