Closed Bug 911085 Opened 7 years ago Closed 7 years ago

Workers postMessage doesn't set its return value

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: Ms2ger, Assigned: baku)

Details

Attachments

(1 file, 3 obsolete files)

So we end up reading the callee back.
Test case: type "postMessage()" into http://mozilla.pettay.fi/workerconsole/
Attached patch patch (obsolete) — Splinter Review
Attachment #798521 - Flags: review?
Attachment #798521 - Flags: review? → review?(mrbkap)
Attached patch patch (obsolete) — Splinter Review
mochitest
Attachment #798522 - Flags: review?(mrbkap)
We really need to fix up all the JSNatives in dom/workers.
Comment on attachment 798522 [details] [diff] [review]
patch

r=me on this, but khuey's right: there's a bunch more functions that need this treatment.
Attachment #798522 - Flags: review?(mrbkap) → review+
Comment on attachment 798521 [details] [diff] [review]
patch

I think this was technically subsumed by attachment 798522 [details] [diff] [review], but r=me twice!
Attachment #798521 - Flags: review?(mrbkap) → review+
Attached patch patch (obsolete) — Splinter Review
Attachment #798521 - Attachment is obsolete: true
Attachment #798522 - Attachment is obsolete: true
Attached patch patchSplinter Review
rebased
Attachment #798770 - Attachment is obsolete: true
Please file another bug on fixing up everything else.
Assignee: nobody → amarchesini
https://hg.mozilla.org/mozilla-central/rev/61788b5c3d55
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.