911101 - Test failure 'No item selected for element ID: historyMode' in testDisableCookies.js testEnableCookies.js testRemoveAllCookies.js testRemoveCookie.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

Failure:   No item selected for element ID: historyMode
Branches:  mozilla-esr17
Platforms: all

mozmill-1.5.22 introduced a new regression http://mozmill-crowd.blargon7.com/#/functional/report/3c3cd991de01b704f3f65783a142b753
It only affects ESR17
 
The regression was introduced by bug 871441

Comment 1

[Andrei Eftimie]

This will start failing on CI once we run the tests with mozmill 1.5.22, so we might want to quickly fix it, or disable these tests on ESR17.

Since ESR17 is near its EOL, just skipping them might be viable.

Comment 2

[Andreea Matei [:AndreeaMatei]]

The problem seems to be at scrollIntoView(), if I comment out that line the test passes. Looking more into this and have them fix asap.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Bug 907983 has nothing to do with this bug. Removing from dependency tree.

Comment 4

[Andreea Matei [:AndreeaMatei]]

Attachment: skipEsr17.patch

Adding skip patch for esr17 to avoid future failures. Removed the litmus code since we don't use it anymore.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Same on staging with mozmill 1.5.22:
http://mozmill-staging.blargon7.com/#/functional/reports?branch=17.0&platform=All&from=2013-08-30&to=2013-08-30

I thought scrollIntoView() works across all supported branches. Wasn't it something we tested with Mozmill 2.0? I wonder if we can circumvent the issue in the test. Might be that we make use of the wrong element?

Comment 6

[Andrei Eftimie]

ESR17 under mozmill 2.0 is really broken: http://mozmill-crowd.blargon7.com/#/functional/report/3c3cd991de01b704f3f65783a143a200

Comment 7

[Andreea Matei [:AndreeaMatei]]

From the discussion in bug 780957, I understand it was added until FF 19 :(

We could fix it in the tests for esr only, by not using select there, like in testPrefferedLanguage.js

Comment 8

[Andrei Eftimie]

Comment on attachment 797806 [details] [diff] [review]
skipEsr17.patch

Review of attachment 797806 [details] [diff] [review]:
-----------------------------------------------------------------

Please fix the noted issue.
Other than that it looks good.

::: tests/functional/testPreferences/testRemoveAllCookies.js
@@ +79,5 @@
>  }
>  
> +setupModule.__force_skip__ = "Bug 911101 - Test failure 'No item selected for " +
> +                             "element ID: historyMode'";
> +teardownModule.__force_skip__ = "Bug 911101 - Test failure 'No item selected for " +

This test does not have a teardownModule, hence it fails here.

Comment 9

[Andreea Matei [:AndreeaMatei]]

Attachment: skipEsr17.patch

Thanks for catching that. I was in a hurry and focused on the skip results.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

(In reply to Andrei Eftimie from comment #6)
> ESR17 under mozmill 2.0 is really broken:
> http://mozmill-crowd.blargon7.com/#/functional/report/
> 3c3cd991de01b704f3f65783a143a200

Check that with a more recent esr17 version and file bugs for Mozmill 2.0 accordingly.

Comment 11

[Tracy Walker [:tracy]]

is this failure http://mozmill-release.blargon7.com/#/functional/report/3c3cd991de01b704f3f65783a1398f91 The cookie has been removed - got 'false' related to this bug?

Comment 12

[Andreea Matei [:AndreeaMatei]]

Doesn't look like it, it's on Mozmill 1.5.21 still, so it couldn't be.

Comment 13

[Andrei Eftimie]

Comment on attachment 797818 [details] [diff] [review]
skipEsr17.patch

Review of attachment 797818 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/f437e5c353a2 (mozilla-esr17)

Comment 14

[Andreea Matei [:AndreeaMatei]]

Attachment: patch v1

We can't backout the skip patch due to the moving of tests in remote.

Reports remote:
Linux: http://mozmill-crowd.blargon7.com/#/remote/report/837c1e0f361ac93453ee69721990dfee
OS X: http://mozmill-crowd.blargon7.com/#/remote/report/837c1e0f361ac93453ee6972199114d1
Windows: http://mozmill-crowd.blargon7.com/#/remote/report/837c1e0f361ac93453ee697219913119

Functional:
Linux: http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee69721990f2fa
OS X: http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee6972199125e1
Windows: http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee697219914d26

And a sanity check with 2.0: http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee6972199151d1

Comment 15

[Andrei Eftimie]

Comment on attachment 810461 [details] [diff] [review]
patch v1

Review of attachment 810461 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/362e4f5de531 (mozilla-esr17)