911145 - Scratchpad and Browser Console keyboard shortcuts should work in the Browser Console

Status: RESOLVED WONTFIX

(DevTools :: Console, defect, P2)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Shift-F4 should open the Scratchpad in the Browser Console.
Ctrl/Cmd+Shift+J should toggle the Browser Console in the Browser Console.

Bug 907316 covered the same things for the detached devtools toolbox window.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Patch

This seems to work for me locally.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Wes Kocher (:KWierso) from comment #1)
> Created attachment 797831 [details] [diff] [review]
> Patch
> 
> This seems to work for me locally.

Ooh, I need to add the localization note to the new strings to make sure they stay in sync with their counterparts elsewhere.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Dave, you said you had put some comments here for me, but it doesn't look like they actually went through. Wanna try again? :)

Comment 4

[Dave Camp (:dcamp)]

You should be able to include toolbox.DTD to get the strings you need rather than adding a new copy - should only need one copy each in DTD and properties files.

Looks good other than that, r+ with that change made.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Can this land?>

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think we still need to address comment 4's suggestion, but I'm not sure when I'll have time to do it. Would be happy to have someone else finish it up and land it... :)

Comment 7

[Rob Campbell [:rc] (:robcee)]

Wes, mind if I unassign you? I'm happy to finish this but in case you were thinking of getting back to it I don't want to stomp on it.

thanks for the patch. :)

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Rob Campbell [:rc] (:robcee) from comment #7)
> Wes, mind if I unassign you? I'm happy to finish this but in case you were
> thinking of getting back to it I don't want to stomp on it.
> 
> thanks for the patch. :)

Have at it.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Scratchpad will be removed (Bug 1519103 - scheduled for Q2), so I think we can close this one.