911150 - elpais.com mobile site opens blank tab on video start

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Hallvord R. M. Steen [:hallvors]]

Clicking/tapping the video to play it opens an empty tab.

JS apparently sets a target="_blank" attribute on a javascript: link that wraps the "view video" button:

http://ep01.epimg.net/m/js/comun.js

        if ('MozActivity' in window)  { // Firefox OS    
            activaBotonAtras();

            var enlaces = document.getElementsByTagName("a");
            var total_enlaces = enlaces.length;
            for ( i = 0 ; i < total_enlaces ; i++ ) {  // los enlaces que no son de EL PAÍS se tienen que abrir "fuera"
                if ( ! enlaces[i].getAttribute("href").match("/m/") ) 
                    enlaces[i].setAttribute("target","_blank"); 
                    else  
                    enlaces[i].setAttribute("target","_self"); 
            }


so tapping the video to start it makes the browser open a new tab for this javascript:void(0) URL:


	<a tabindex="20" target="_blank" class="posicionador" id="posicionador_1377758184_726257_1377857041" title="Ver vídeo" href="javascript:void(0)">
		<span class="boton_video"></span>

Related to bug 790893

Comment 1

[Hallvord R. M. Steen [:hallvors]]

https://mobile.twitter.com/MozWebCompat/status/373416430324445184
not setting [sitewait] because I'm not sure how responsive they are on Twitter, it seems like quite a generic account.

Comment 2

[:Harald Kirschner :digitarald]

I pinged my contacts, linking to this bug.

Comment 3

[Karl Dubost💡 :karlcow]

Harald any news about it?

Comment 4

[Adam Stevenson [:adamopenweb]]

Trying the marketing email [e-mail].

Comment 5

[Hallvord R. M. Steen [:hallvors]]

The simplest fix would be to find this code in the commun.js file:

  if ( ! enlaces[i].getAttribute("href").match("/m/") ) 
     enlaces[i].setAttribute("target","_blank"); 

The match() call is wrong because match() expects a regular expression, not a string.

El Pais developers should fix that and make sure it does not set the target attribute of javascript: links, for example by adding them to the matching. The correct version would be for example this:


  if ( ! enlaces[i].getAttribute("href").match(/(^javascript:|\/m\/)/) ) 
     enlaces[i].setAttribute("target","_blank");

Comment 6

[Hallvord R. M. Steen [:hallvors]]

Harald, can we try going through your contacts again? Send them this link: http://webcompat.com/simplebug/?id=911150

Comment 7

[Ismael Gonzalez [:basiclines]]

I will try to help you with this guys as i've been working on ELPAIS.com some years ago and i still have communications with some team-mates

Comment 8

[:Harald Kirschner :digitarald]

Pinged the dev team again.

Comment 9

[:Harald Kirschner :digitarald]

Thanks to the elpais team it is fixed and live.

Comment 10

[Karl Dubost💡 :karlcow]

Tested on http://elpais.com/m/elpais/videos.html and working.
Thanks Harald.