911171 - Booting up unagi with latest master returns JavaScript Error: "TypeError: elem is null" {file: "app://system.gaiamobile.org/js/init_logo_handler.js"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Florin Strugariu [:Bebe]]

Attachment: Logcat of the issue on line 670

STR:
1. Flash latest build
2. start a logcat and boot up the device


Expected:
2. The device boots up as expected

Actual:
2: The device returns 
E/GeckoConsole(  110): [JavaScript Error: "TypeError: elem is null" {file: "app://system.gaiamobile.org/js/init_logo_handler.js" line: 67}]

Build:
Gecko  http://hg.mozilla.org/mozilla-central/rev/c7459bc8e449
Gaia  407fbfb6a9de68ec4db2f0f3dc6c67463e293f47
BuildID 20130830040204
Version 26.0a1

Comment 1

[Florin Strugariu [:Bebe]]

This is blocking Gaia-UI automation

All our tests are failing because of this issue
Changing the bug to critical

Comment 2

[Florin Strugariu [:Bebe]]

Exact logcat issue:

E/Profiler(  328): Registering start signal
I/InputReader(  110): Reconfiguring input devices.  changes=0x00000004
I/InputReader(  110): Device reconfigured: id=7, name='atmel-touchscreen', surface size is now 320x480, mode is 1
E/GeckoConsole(  110): [JavaScript Error: "TypeError: elem is null" {file: "app://system.gaiamobile.org/js/init_logo_handler.js" line: 67}]
I/Gecko   (  110): -*- WifiWorker component: detected SDK version 15
E/GeckoConsole(  110): [JavaScript Error: "callback is undefined" {file: "jar:file:///system/b2g/omni.ja!/components/RILContentHelper.js" line: 1760}]
I/Gecko   (  110): -*- WifiWorker component: State change: INITIALIZING -> INACTIVE
I/Gecko   (  110): -*- WifiWorker component: Connected to supplicant
I/Gecko   (  110): -*- WifiWorker component: Got mac: 48:28:2f:f9:be:07

Comment 3

[Bob Silverberg [:bsilverberg]]

The last know good build is:

Gecko  http://hg.mozilla.org/mozilla-central/rev/8451e35a8a50
Gaia   98b82e7574d52ba331add18c617e08d8784ccf4a
BuildID 20130829040202
Version 26.0a1

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Here's the relevant pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8451e35a8a50&tochange=c7459bc8e449

Comment 5

[Jason Smith [:jsmith]]

The JS error is coming from changes seen in bug 900838.

https://github.com/mozilla-b2g/gaia/commit/a39ec638fd0e9d32eeb7643f272333b9f06a2941

John - Can you backout the above commit?

Note - Apparently I don't have access to bug 900838, so I can't comment in that bug.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Gaia changes are: https://github.com/mozilla-b2g/gaia/compare/98b82e7574d52ba331add18c617e08d8784ccf4a...407fbfb6a9de68ec4db2f0f3dc6c67463e293f47

Given the message, I would suspect https://github.com/mozilla-b2g/gaia/commit/a39ec638fd0e9d32eeb7643f272333b9f06a2941

KM Lee: Any ideas?

Comment 7

[Bob Silverberg [:bsilverberg]]

There also seems to be a problem with the desktop build. I am not getting any JavascriptExceptions, but when the b2g app launches nothing appears on the monitor. Tests still pass, but nothing appears on the screen.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Screenshot of JavaScript error console for B2G desktop build

I replicated the issue with the B2G desktop client and attach a screenshot (I was unable to copy/paste for for some reason). This is not the same error but may be related.

Comment 9

[Jason Smith [:jsmith]]

Backed out in https://github.com/mozilla-b2g/gaia/commit/c3691f5278c99a078d611c9a5f783dab77a8ec6f.

Closing as fixed by backout. Leaving needinfo though on Rex, cause I need him to reopen the associated bug in question per the backout (I don't have access). Could you cc me on that bug also?

Comment 10

[Jason Smith [:jsmith]]

Also - Can you cc jhford on the associated bug?

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

CC'ed Jason and John on bug 900838.

The bug is still waiting for landing Gecko part, but seems the error message
is unrelated with that. I guess the error message should be some cases
I didn't considered..

I did reproduced the error message, but I can still boot normally. So I'll
first try to eliminate the error, but since I'm not sure whether just
eliminating the error solves the problem, is there any document or instruction
that I can ensure after finishing the patch?

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

updated the patch.
This should be fine I guess.. I'll merge it after confirming it doesn't cause
regression again.
https://github.com/rexboy7/gaia/commit/62c53d16beb8d2149ee3b5fc316a7676cd0fba83

Comment 13

[Florin Strugariu [:Bebe]]

This was fixed with build:
http://qa-selenium.mv.mozilla.com:8080/job/b2g.unagi.mozril.gaia.master.ui/143/

Thanks for the help all

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I've raised bug 911751 for the desktop client issue, which I believe to be unrelated.