911243 - Enable test_interfaces.html on B2G

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=bd4d68d02385

Comment 1

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b04073aaa278

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Backed out for Android failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d9e5022bf6c

https://tbpl.mozilla.org/php/getParsedLog.php?id=27246437&tree=Mozilla-Inbound

Comment 3

[Masatoshi Kimura [:emk]]

Hm, Android doesn't contain "Mobile" in the user-agent string?

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: patch v2

Android 4.0 Panda is using "Tablet" in the UA token.
Either "Tablet" or "Mobile" will always be defined on Android and B2G:
https://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp?rev=9d925d047ba5#683
Try result:
https://tbpl.mozilla.org/?tree=Try&rev=23413bdab693

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 798162 [details] [diff] [review]
patch v2

Review of attachment 798162 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/general/test_interfaces.html
@@ +602,5 @@
>  function createInterfaceMap(isXBLScope) {
>    var version = SpecialPowers.Cc["@mozilla.org/xre/app-info;1"].getService(SpecialPowers.Ci.nsIXULAppInfo).version;
>    var isNightly = version.endsWith("a1");
>    var isRelease = !version.contains("a");
> +  info(navigator.userAgent);

I assume you'll drop this before landing.

@@ +629,1 @@
>        interfaceMap[entry.name] = true;

Could this be written as 

interfaceMap[entry] =
  typeof(entry) === "string" ||
  (entry.xbl === isXBLScope &&
   entry.desktop === isDesktop &&
   entry.release === isRelease);

or something like that?

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to :Ms2ger from comment #5)
> ::: dom/tests/mochitest/general/test_interfaces.html
> @@ +602,5 @@
> >  function createInterfaceMap(isXBLScope) {
> >    var version = SpecialPowers.Cc["@mozilla.org/xre/app-info;1"].getService(SpecialPowers.Ci.nsIXULAppInfo).version;
> >    var isNightly = version.endsWith("a1");
> >    var isRelease = !version.contains("a");
> > +  info(navigator.userAgent);
> 
> I assume you'll drop this before landing.

Sure.

> @@ +629,1 @@
> >        interfaceMap[entry.name] = true;
> 
> Could this be written as 
> 
> interfaceMap[entry] =
>   typeof(entry) === "string" ||
>   (entry.xbl === isXBLScope &&
>    entry.desktop === isDesktop &&
>    entry.release === isRelease);
> 
> or something like that?

No. De Morgan's laws don't hold here because both |undefined === true| and |undefined === false| will be evaluated to false. (I admit this code is a bit tricky.)

Comment 7

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aef6bbfe9db3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aef6bbfe9db3