Closed Bug 911295 Opened 8 years ago Closed 8 years ago
crash in java
.lang .Illegal Argument Exception: Cannot handle null URLs in enter Editing Mode at org .mozilla .gecko .Browser App .enter Editing Mode(Browser App .java)
This bug was filed from the Socorro interface and is report bp-c7427fef-91da-4930-9a35-513c52130827. =============================================================
Hey mcomella, regression from bug 905088?
Short answer: yes. Long answer: The patch from bug 905988 validates the url argument and throws an exception if it's null. We never use url without checking if it was null first within enterEditingMode(url), so we never ran into this with a NullPointerException before. The patch in bug 905988 makes the code safer so we should try to track down the cause of the null, rather than backing out the patch. According to crash-stats, the crash seems to occur at boot so I'm guessing Tabs.getInstance().getSelectedTab() is returning null because the open tabs have not yet loaded. Perhaps if this is the case and the tab instance is null, we should pass the empty string to enterEditingMode(url) (but this should be researched further).
Those are all within the first minute after launch and this is the #2 topcrash on 26.0a1 Nightly at this time.
Comment on attachment 799547 [details] [diff] [review] Use empty URL if entering editing mode on startup with no tabs Review of attachment 799547 [details] [diff] [review]: ----------------------------------------------------------------- r+, but you may want to add a javadoc comment to enterEditingMode(String) explaining what passing an empty string should do.
Attachment #799547 - Flags: review?(michael.l.comella) → review+
Pushed with the suggested changes: https://hg.mozilla.org/integration/fx-team/rev/1c7b17c72cfd
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.