911364 - New GeckoView instances aren't connected to Gecko when Activity is recreated

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Using a test app built with GeckoView:
1. Load web content into test app
2. Rotate device
3. GeckoView goes "white"
4. Attempt to reload content into GeckoView

It fails to load anything.

Comment 1

[Ben Bucksch (:BenB)]

Maybe caused by 891634?

Comment 2

[Ben Bucksch (:BenB)]

Maybe caused by bug 891634?

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Connect new GeckoView to Gecko after rotation

Rotating recreates the Activity and the GeckoView, so we need to hook the new GeckoView up to Gecko. This now draws the page after rotation, but there's several question/issues that still need to be sorted out:

1) With this patch, I've noticed that after rotating/zooming, touch events are misaligned with where I'm actually touching on the screen.
2) We call GeckoAppShell.registerEventListener() with 'this' as the listener, so the destroyed GeckoView is leaked whenever we rotate. We'll need to figure out a way to unregister these listeners (onDetachedFromWindow?) or decouple them from GeckoView.
3) What happens when we receive events from Gecko while there is no view available (e.g., we're in the middle of a rotation, or we're in the background with "Don't Keep Activities" enabled)? With the current implementation, it's possible that the GeckoView client misses something like Gecko:Ready, and the application becomes borked.

Comment 4

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/b2e51c4467a4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2e51c4467a4