Closed Bug 911518 Opened 9 years ago Closed 9 years ago

Add YCbCr_420_SP_TILED's color conversion to android::ColorConverter in nexus4

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 911548

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

For nexus4's build android JB' AOSP source is used. But the AOSP's default android::ColorConverter do not support color conversion from HAL_PIXEL_FORMAT_YCbCr_420_SP_TILED(0x7FA30C03) to RGB 565. Without the conversion, video frame can not draw to canvas and video app can not generate video's thumbnail. Need to add the color conversion.
Blocks: 871364
Assignee: nobody → sotaro.ikeda.g
In qcom's hw, the color conversion is normally done by "libmm-color-convertor.so". The rom include the library. So, the conversion should be possible.
codeaurora's source support the conversion. By applying the related part to aosp's srouce, the conversion might be possible in nexus-4.
https://www.codeaurora.org/cgit/external/simcom/platform/frameworks/av/tree/media/libstagefright/colorconversion/ColorConverter.cpp?h=jb-8930-master-dsda
Created a rom applying the change in comment #2. But failed to load a function in the following. nuxus4's related function seems different.

> convertFn convertNV12Tile = (convertFn)dlsym(lib, "_ZN7android7convertENS_18ColorConvertParamsES0_Ph");
Checked the function's symbol name by using following command.
> nm -D ./libmm-color-convertor.so
Confirmed the thumnail generation in video app. To confirm it, I did following.
- Apply attachment 798240 [details] [diff] [review] in Bug 871364.
- Create directory by Bug 910498 Comment 18
- push h.264 video to nexus 4
blocking-b2g: --- → koi?
Blocks: gonk-jb
No longer blocks: 871364
Depends on: 871364
Add Code Aurora Forum's copyright.
Attachment #798241 - Attachment is obsolete: true
mwu, does "nexus-4 build" continue to use aosp? not caf?
Flags: needinfo?(mwu)
Nexus 4 is currently on AOSP, but it may change to CAF if we start making builds for it.
Flags: needinfo?(mwu)
Merge the patch to Bug 911548.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 911548
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.