Closed
Bug 911576
Opened 11 years ago
Closed 11 years ago
[Flatfish] fix bug of unwatch for screen_layout.js
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gduan, Unassigned)
Details
Attachments
(1 file)
Error when trying to access this.queries[name].matches to do unwatch.
|
Reporter | |
Comment 1•11 years ago
|
||
Hi Tim,
This patch has fixed a small bug for unwatch function.
In addition, if a user watch some specific mediaquery by calling watch, I think it will be helpful if they can directly check the returning value(boolean) of getCurrentLayout('NAME'). So, I also make a small change in this patch.
Please kindly review. Thanks.
Attachment #798297 -
Flags: review?(timdream)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 798297 [details]
PR to master
Nit: update commit message.
You should write some tests for your script too :)
Attachment #798297 -
Flags: review?(timdream) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Thanks Tim,
I will write test case for the first applied app.
Merge into master,
https://github.com/mozilla-b2g/gaia/commit/f540b29767e38f70bc6e5b3ae75b73346cf780d4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•