911592 - The configure.in test checking for gcc bug 26905 is x86 specific, but applied to all archs

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Martin Husemann]

When using gcc versions with gcc bug 26905 fixed (i.e. anything >= 4.2) on non-x86 architectures, configure still assumes the bug to be present and erroneously does not set WRAP_STL_INCLUDES and others.

This happens because the compiled conftest.cc is greped for @PLT in function calls - but @PLT is only valid on a few special architecturs, while in general only a .private declaration is emmited in the function prologue.

A proper conftest maybe pretty hard - is it actually needed anymore, i.e. is an old enough gcc to have the bug still supported for building? If not, it could be reduced to a simple gcc or gcc version test.

The overall effect of the miss-detection is only a few headers less installed in the SDK and slightly changed compiler options, which is why this probably "silently failed" since ages without anyone noticing.

Comment 1

[Mike Hommey [:glandium]]

You're right, neither gcc bug 26905 nor gcc bug 20297 apply to a supported gcc version. We can just remove these tests.

Comment 2

[Martin Husemann]

Attachment: Remove obsolete tests for no-longer-supported gcc versions

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 812622 [details] [diff] [review]
Remove obsolete tests for no-longer-supported gcc versions

Review of attachment 812622 [details] [diff] [review]:
-----------------------------------------------------------------

You need to adjust js/src/configure.in, too.

::: configure.in
@@ +2638,5 @@
> +        WRAP_SYSTEM_INCLUDES=1
> +        STL_FLAGS='-I$(DIST)/stl_wrappers'
> +        WRAP_STL_INCLUDES=1
> +      else
> +        VISIBILITY_FLAGS='-fvisibility=hidden'

This doesn't match current behavior: we didn't set -fvisibility=hidden when visibility pragma is not supported.

Comment 4

[Martin Husemann]

Attachment: New try: remove obsolete tests for no-longer-supported gcc versions

hope I got the nesting correct this time

Comment 5

[Takanori MATSUURA]

This configure.in test no longer exists.