Closed
Bug 911968
Opened 11 years ago
Closed 10 years ago
[HD]Center rotation point of refresh icon off
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)
Tracking
(b2g-v1.1hd affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.1hd | --- | affected |
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: helix, visual design, visual-tracking, jian)
Attachments
(8 files)
7.26 MB,
video/mp4
|
Details | |
2.75 KB,
image/png
|
epang
:
feedback+
|
Details |
954 bytes,
image/png
|
Details | |
183 bytes,
text/html
|
jrburke
:
review+
|
Details |
2.23 KB,
application/zip
|
Details | |
2.56 MB,
video/mp4
|
Details | |
46 bytes,
text/x-github-pull-request
|
jj.evelyn
:
review+
|
Details | Review |
5.44 MB,
video/quicktime
|
epang
:
feedback+
|
Details |
Pavel, when the refresh icon is pressed in the email app the center point seems to be off. It rotates a bit wobbly. Can you check the center rotation point? See the video i've attached. This only occurs in HD.
Reporter | ||
Comment 1•11 years ago
|
||
Wayne, I marked as HD+ since this only occurs in HD. If you can make it + that would be great! Thanks
Flags: needinfo?(wchang)
Assignee | ||
Comment 3•11 years ago
|
||
Hey Eric, because we rotate the image and the dimensions of the image are 45x45 px for HD the center is 22.5px so ... the circle of the icon need to be centered there but we can't do this :) that's why I made 46x46 px icon and I just resize the circle to 34px diameter (even number) but the image need to be created from some vector image, can you do this for me :)?
Attachment #803711 -
Flags: feedback?(epang)
Flags: needinfo?(epang)
Reporter | ||
Comment 4•11 years ago
|
||
Attached! :) Let me know if I need to make any tweaks to it.
Flags: needinfo?(epang)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #804237 -
Flags: review?(sjochimek)
Comment 6•11 years ago
|
||
Comment on attachment 804237 [details]
patch for Gaia/master
As this is a patch for master,
Pavel: Can you provide update for all refresh.png version ?
Thanks.
Attachment #804237 -
Flags: review?(sjochimek)
Assignee | ||
Comment 7•11 years ago
|
||
Hey Eric, can you provide the rest of the refresh.png images for all resolutions (SD and x2.0)?
Flags: needinfo?(epang)
Reporter | ||
Comment 8•11 years ago
|
||
Hey Pavel, here is the icon at sd and 2x. Let me know if there's anything else that's needed :)
Flags: needinfo?(epang)
Assignee | ||
Updated•11 years ago
|
Attachment #804237 -
Flags: review?(sjochimek)
Reporter | ||
Comment 9•11 years ago
|
||
Comment on attachment 803711 [details] refresh@1.5x.png The icon looks good to me :)
Attachment #803711 -
Flags: feedback?(epang) → feedback+
Comment 10•11 years ago
|
||
Is it normal that the icons are differents ? Icons(@1x & @2x) should not be all like @1.5x icon ?
Flags: needinfo?(pivanov)
Flags: needinfo?(epang)
Reporter | ||
Comment 11•11 years ago
|
||
(In reply to Sam Joch [:samjoch] from comment #10) > Is it normal that the icons are differents ? > Icons(@1x & @2x) should not be all like @1.5x icon ? Thanks Sam, yes they should be all the same. Pavel do you need me to provide assets?
Flags: needinfo?(epang)
Assignee | ||
Comment 12•11 years ago
|
||
Hey Eric, I updated the 1.5x version ... is this ok now?
Flags: needinfo?(pivanov) → needinfo?(epang)
Reporter | ||
Comment 13•11 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #12) > Hey Eric, > I updated the 1.5x version ... is this ok now? yes, as long as they are all the same :). Thanks!
Flags: needinfo?(epang)
Assignee | ||
Comment 16•11 years ago
|
||
I need r+ from someone ... I will try to find someone who can review the patch.
Flags: needinfo?(pivanov)
Assignee | ||
Updated•11 years ago
|
Attachment #804237 -
Flags: review?(sjochimek) → review?(jrburke)
Comment 17•11 years ago
|
||
Comment on attachment 804237 [details]
patch for Gaia/master
I do not have a hidpi device to test this on, but given that is it just an image swap and looks good when viewed in the diff, r+
Attachment #804237 -
Flags: review?(jrburke) → review+
Assignee | ||
Comment 18•11 years ago
|
||
Landed to master: https://github.com/mozilla-b2g/gaia/commit/354f3b8d686427a198a2f1ea7691bdfc62c80ddd Landed to v1.1.0hd: 4de25ada0decb3b994f7d6916e1eb99ef6e01912
Updated•11 years ago
|
Flags: needinfo?(sjochimek)
Comment 20•11 years ago
|
||
I still can reproduce this bug on V1.1.0hd and Central(V1.3) after the patch landed. Attaching the video. Thanks. * Test Build: + V1.1.0hd - Gaia: ff5fdef17c997deb000c386c809dbf2617656c9b - Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/42e2dbb0d538 - BuildID 20131121042202 - Version 18.0 => Can reproduce + Central (V1.3) - Gaia: c26480b22ce28c812c347290dd4bad090d83db6f - Gecko: http://hg.mozilla.org/mozilla-central/rev/597287004ff5 - BuildID 20131120062258 - Version 28.0a1 => Can reproduce
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 21•11 years ago
|
||
Comment 22•11 years ago
|
||
Pavel, Can you correct this? Looking at closing off by 11/28.
Flags: needinfo?(pivanov)
Comment 23•11 years ago
|
||
After comment 20 modifying 1.1hd flag to Affected. Please feel free to modify it if I am wrong.
Reporter | ||
Comment 24•11 years ago
|
||
(In reply to Beatriz Rodríguez [:brg] from comment #23) > After comment 20 modifying 1.1hd flag to Affected. Please feel free to > modify it if I am wrong. Hey Pavel I'm going to add this to out blocking the 1.3 refresh. We need this fixed in in both HD and master.
Reporter | ||
Updated•11 years ago
|
Blocks: 1.3-visual-refresh
Whiteboard: helix vsd → helix, visual design, visual-tracking, jian
Assignee | ||
Comment 25•11 years ago
|
||
Hey Eric, this one need to be tested on HD device, can you do that for me? Thanks :)
Attachment #8341571 -
Flags: feedback?(epang)
Flags: needinfo?(pivanov)
Reporter | ||
Comment 26•11 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #25) > Created attachment 8341571 [details] [review] > patch for Gaia/master > > Hey Eric, > this one need to be tested on HD device, can you do that for me? Thanks :) Hey Pavel, it looks good on master now, but it's still incorrect on WVGA. Let me know if there's anything I can do to help :). Thanks!
Flags: needinfo?(pivanov)
Comment 27•11 years ago
|
||
Hi Eric/Pavel, We'll need this landed on v1.1HD as soon as possible (in the next day or two if possible), we're wrapping that branch up ;)
Assignee | ||
Comment 28•11 years ago
|
||
Attachment #8341641 -
Flags: feedback?(epang)
Flags: needinfo?(pivanov)
Reporter | ||
Comment 29•11 years ago
|
||
Comment on attachment 8341641 [details]
video
Looks good, thanks Pavel. Wayne can you help review so we can land? thanks!
Attachment #8341641 -
Flags: feedback?(epang) → feedback+
Reporter | ||
Updated•11 years ago
|
Attachment #8341571 -
Flags: feedback?(epang)
Assignee | ||
Updated•11 years ago
|
Attachment #8341571 -
Flags: review?(wchang)
Comment 30•11 years ago
|
||
Comment on attachment 8341571 [details] [review] patch for Gaia/master looks like good to me. Thanks!
Attachment #8341571 -
Flags: review?(wchang) → review+
Comment 31•11 years ago
|
||
merged into gaia master: https://github.com/mozilla-b2g/gaia/commit/c061ad61abd64f050c48805b27baf047e90bf084
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 32•11 years ago
|
||
(In reply to Evelyn Hung [:evelyn] from comment #31) > merged into gaia master: > https://github.com/mozilla-b2g/gaia/commit/ > c061ad61abd64f050c48805b27baf047e90bf084 Thanks Evelyn!
Comment 33•10 years ago
|
||
The icon looks good on master build. We still need your help to uplift this patch to V1.1.0hd because this is hd+ bug. Thanks! * Test Build: - Gaia: 6415b8b44068596404c10365394544e94edd5ce5 - Gecko: http://hg.mozilla.org/mozilla-central/rev/12ea03a70243 - BuildID 20131211040203 - Version 29.0a1
Comment 34•10 years ago
|
||
Could I have your help to uplift this patch to V1.1.0hd? Thanks!
Comment 35•10 years ago
|
||
This is hd+ bug. Please uplift this patch to V1.1.0hd. Thanks!
Assignee | ||
Comment 37•10 years ago
|
||
Hey guys, We land the new [BB]Tabs few days ago and I have a fix for this bug too (the problem was bigger than I thought) I will try to create a patch tomorrow
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•10 years ago
|
Flags: needinfo?(jhford)
Comment 38•10 years ago
|
||
Any update? Thanks!
Comment 39•10 years ago
|
||
Mass-modify - removal of no longer relevant blocking flags
blocking-b2g: hd+ → ---
Comment 40•10 years ago
|
||
It looks like this bug was landed in master, but was only reopened to track uplift status. It does not seem relevant anymore, so I am going to mark as resolved again.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•