912005 - [Bluetooth][HFP][CDMA] (Gaia dialer) Inform gecko bluetooth of call manipulations for CLCC

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

For HFP CLCC command under CDMA, Gecko BT has to be informed of following call manipulations:
- answer waiting call
- reject waiting call
- switch active <-> held calls
- (no support in v1.2 RIL) put an active call on hold and make a MO call
- (no support in v1.2 RIL) merge calls

Two ways to notify BT: DOM API from dialer or event from RIL. We prefer RIL event as it also works for future 3rd-party apps and doesn't require super review. Still two cons remain: 1) RIL doesn't know 'reject waiting call' (A+W -> A) as dialer only removes notification and does nothing to RIL. And 2) RIL code would become messy and all other components can register to know these call manipulations.

Need to choose one way otherwise BT fails PTS certification test.

Comment 1

[Ben Tian (inactive)]

Gabriele & Etienne,

This is Ben working on gecko bluetooth for CDMA. I'd like to add new webapi functions to make dialer notify gecko bluetooth of call manipulations (mentioned in comment 0). The reason to choose dialer instead of RIL is that only dialer knows 'reject waiting call' action in CDMA. Please let me know your opinion on the dialer change.

CLCC command requires gecko bluetooth notify BT headset of all current call states. In GSM gecko bluetooth is informed of call state changes directly from RIL; however in CDMA only 1 call object exists and gecko bluetooth can't know precise call states of the two numbers. So instead gecko bluetooth needs to know these call manipulations to determine the precise call states in CDMA.

Comment 2

[Etienne Segonzac (:etienne)]

It's more of a platform decision, making the API call from the dialer should be pretty straightforward whatever solution is chosen.

Comment 3

[Ben Tian (inactive)]

Thanks Etienne.

The actions bluetooth needs to know from dialer are:
- answer a waiting call
- reject a waiting call
- switch active and held calls

I'll list the api in detail and discuss with you later this week.

Comment 4

[Gabriele Svelto [:gsvelto]]

(In reply to Ben Tian [:btian] from comment #3)
> The actions bluetooth needs to know from dialer are:
> - answer a waiting call

In CDMA call waiting mode this is done by invoking the TelephonyCall.hold() method, it might be possible to modify the RIL to send that information.

> - switch active and held calls

Same as above.

> - reject a waiting call

This is the nasty case, CDMA has no notion of rejecting an incoming call so there's nothing to reflect it and only the dialer knows this has happened so this does require some other method.

Comment 5

[Ben Tian (inactive)]

Attachment: WIP dialer patch v1

The WIP calls following 3 new functions to inform bluetooth adapter in CDMA:
 1) OnAnswerWaitingCall - dialer answers the waiting call
 2) OnIgnoreWaitingCall - dialer ignores the waiting call
 3) OnToggleCalls - dialer toggles active and held calls
This gaia patch works with gecko patches in bug 925638.

[TODO] Revise code to get bluetooth adapter and handle errors.

Comment 6

[Ben Tian (inactive)]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/12812

The PR gets bluetooth adapter in dialer to notify call operations in CDMA. Note the related webidl change is under review in bug 925638.

Etienne, can you review my dialer change? Thanks.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 816536 [details]
link to https://github.com/mozilla-b2g/gaia/pull/12812

f=me for the helper part. The variable name `helper` is too generic. Maybe use `bluetoothHelper`?

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 816536 [details]
link to https://github.com/mozilla-b2g/gaia/pull/12812

Thanks for the clean patch!

Did 2 small (but important ;)) comments on github.

But mainly this needs unit tests.

I think we need:
* A mock_bluetooth_helper.js
* sinon spies [1] to make sure that the right calls are made in calls_handler_test.js
* a mock_navigator_moz_bluetooth.js
* coverage for the basic logic in a newly created bluetooth_helper_test.js

[1] http://sinonjs.org/docs/#spies

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Nominating koi?,
since bug 917344(koi+) can be done on top of bluetooth_helper introduced in this patch.

Comment 10

[Ben Tian (inactive)]

Remove koi? as Rex will integrate bluetooth_helper into bug 917344's fix directly.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

1.3+ to complete HFP support for CDMA

Comment 12

[Ben Tian (inactive)]

Change owner to Rex for gaia revision. He has integrated part of comment 6 patch in bug 917344.

Rex, let me know once you complete the patch and I'll test it again. Thanks for the help.

Comment 13

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch / with unit test

Hello Ben:
The patch is done. Basically just rebase the original patch onto current
bluetooth_helper and add unit test.
Would you make a test to make sure if the functions are all OK?

Comment 14

[Ben Tian (inactive)]

Comment on attachment 824509 [details]
Patch / with unit test

The patch works as expected. Thanks for the prompt help.

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 824509 [details]
Patch / with unit test

Thank you for verifying Ben!

Etienne may you help review this patch?

Comment 16

[Etienne Segonzac (:etienne)]

Comment on attachment 824509 [details]
Patch / with unit test

Perfect, thanks Rex, thanks Ben!

Comment 17

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for timely reviewing, Etienne!

And thanks Ben and Arthur for working on this patch. Merged:

master
https://github.com/mozilla-b2g/gaia/commit/c942ea58a74ca425fa9e974b2e340b19b8db3893