912012 - [Messages] we can trigger 2 navigation requests in the same time

Status: RESOLVED DUPLICATE of bug 1218374

(Firefox OS Graveyard :: Gaia::SMS, defect, P3)

Description

[Julien Wajsberg [:julienw]]

STR:
* have a big sms thread
* tap on it to load it
* immediately tap on the "start new message" icon
=> we move to the "new message" panel, but the sms thread is loading under it.

We should probably forbid any interaction while we're navigating.

I'd like to take this bug as an opportunity to introduce a new Navigation object that would handle all the navigation inside the SMS app.

Comment 1

[Borja Salguero [:borjasalguero]]

Julien, we had an old bug that we could rescue for this purpose. It's https://bugzilla.mozilla.org/show_bug.cgi?id=881469, and there we were talking about the need of adding a 'Navigation' object for handling the navigation. I would like to move forward with this, Wdyt about defining the requirements that we want to accomplish in the other bug,I will create the tests first, and then I'll implement the code. Does it sounds good?

Comment 2

[Julien Wajsberg [:julienw]]

You're right, the navigation object is bug 881469. I commented there :)

Lets keep this bug open as we might need to do something more here.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

add to backlog bug 891754

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

QAWANTED to see if this still happens

Comment 5

[Julien Wajsberg [:julienw]]

I think it does not, bug 881469 handled this case.

Let's see what QA says.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

This issue is reproducible on Flame 3.0. See video for reproduction demonstration:

https://www.youtube.com/watch?v=ZTJmQv-Nuy0

Tested on:
Device: Flame 3.0 Master (full flashed 319MB KK)
BuildID: 20150421010201
Gaia: a8e4f95dce9db727dda5d408b038f97fb4296557
Gecko: 7b823253d9f2
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Comment 7

[Julien Wajsberg [:julienw]]

From my own test we can still trigger 2 navigation requests in the same time but I couldn't manage to reproduce a broken view like the one we see here.

I think this has been properly fixed by bug 1218374.

Maybe we should really prevent interactions while navigating ? I know other apps (eg Contacts) does it.
Let's close this for now.