Closed
Bug 912103
Opened 12 years ago
Closed 12 years ago
about:networking tests
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: robertbindar, Assigned: robertbindar)
References
Details
Attachments
(1 file, 2 obsolete files)
|
5.09 KB,
patch
|
Details | Diff | Splinter Review |
Implement unit tests for most of its functionalities.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → robertbindar
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #799361 -
Flags: review?(jduell.mcbugs)
|
|
Assignee | |
Updated•12 years ago
|
OS: Linux → All
Hardware: x86_64 → All
|
|
Assignee | |
Comment 2•12 years ago
|
||
some minor changes on the manifest files and a rebasing.
Attachment #799361 -
Attachment is obsolete: true
Attachment #799361 -
Flags: review?(jduell.mcbugs)
Attachment #800102 -
Flags: review?(jduell.mcbugs)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #800102 -
Flags: review?(mcmanus)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 800102 [details] [diff] [review]
about_networking_test.patch
Review of attachment 800102 [details] [diff] [review]:
-----------------------------------------------------------------
you don't need r+ from two peers :)
Attachment #800102 -
Flags: review?(mcmanus)
|
|
Assignee | |
Comment 4•12 years ago
|
||
sorry, I saw your r queue was a little more free than jduell's. I need to see if this is going in the right direction before adding some more tests.
|
|
||
Comment 5•12 years ago
|
||
If valentin feels comfortable with this I'm happy to delegate it to him
|
||
Comment 6•12 years ago
|
||
Comment on attachment 800102 [details] [diff] [review]
about_networking_test.patch
Review of attachment 800102 [details] [diff] [review]:
-----------------------------------------------------------------
It looks pretty good so it gets my r+
Attachment #800102 -
Flags: review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
r=valentin.gosu
Attachment #800102 -
Attachment is obsolete: true
Attachment #800102 -
Flags: review?(jduell.mcbugs)
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 8•12 years ago
|
||
|
||
Comment 9•12 years ago
|
||
|
|
||
Comment 10•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•