Closed Bug 912103 Opened 6 years ago Closed 6 years ago

about:networking tests

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: robertbindar, Assigned: robertbindar)

References

Details

Attachments

(1 file, 2 obsolete files)

Implement unit tests for most of its functionalities.
Assignee: nobody → robertbindar
Attached patch about_networking_test.patch (obsolete) — Splinter Review
Attachment #799361 - Flags: review?(jduell.mcbugs)
OS: Linux → All
Hardware: x86_64 → All
Attached patch about_networking_test.patch (obsolete) — Splinter Review
some minor changes on the manifest files and a rebasing.
Attachment #799361 - Attachment is obsolete: true
Attachment #799361 - Flags: review?(jduell.mcbugs)
Attachment #800102 - Flags: review?(jduell.mcbugs)
Attachment #800102 - Flags: review?(mcmanus)
Comment on attachment 800102 [details] [diff] [review]
about_networking_test.patch

Review of attachment 800102 [details] [diff] [review]:
-----------------------------------------------------------------

you don't need r+ from two peers :)
Attachment #800102 - Flags: review?(mcmanus)
sorry, I saw your r queue was a little more free than jduell's. I need to see if this is going in the right direction before adding some more tests.
If valentin feels comfortable with this I'm happy to delegate it to him
Comment on attachment 800102 [details] [diff] [review]
about_networking_test.patch

Review of attachment 800102 [details] [diff] [review]:
-----------------------------------------------------------------

It looks pretty good so it gets my r+
Attachment #800102 - Flags: review+
r=valentin.gosu
Attachment #800102 - Attachment is obsolete: true
Attachment #800102 - Flags: review?(jduell.mcbugs)
Keywords: checkin-needed
Blocks: 915090
https://hg.mozilla.org/integration/fx-team/rev/2a18454f0aa3
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2a18454f0aa3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.