about:networking tests

RESOLVED FIXED in mozilla26

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Robert Bindar, Assigned: Robert Bindar)

Tracking

Trunk
mozilla26
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Implement unit tests for most of its functionalities.
(Assignee)

Updated

5 years ago
Assignee: nobody → robertbindar
(Assignee)

Comment 1

5 years ago
Created attachment 799361 [details] [diff] [review]
about_networking_test.patch
Attachment #799361 - Flags: review?(jduell.mcbugs)
(Assignee)

Updated

5 years ago
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 2

5 years ago
Created attachment 800102 [details] [diff] [review]
about_networking_test.patch

some minor changes on the manifest files and a rebasing.
Attachment #799361 - Attachment is obsolete: true
Attachment #799361 - Flags: review?(jduell.mcbugs)
Attachment #800102 - Flags: review?(jduell.mcbugs)
(Assignee)

Updated

5 years ago
Attachment #800102 - Flags: review?(mcmanus)
Comment on attachment 800102 [details] [diff] [review]
about_networking_test.patch

Review of attachment 800102 [details] [diff] [review]:
-----------------------------------------------------------------

you don't need r+ from two peers :)
Attachment #800102 - Flags: review?(mcmanus)
(Assignee)

Comment 4

5 years ago
sorry, I saw your r queue was a little more free than jduell's. I need to see if this is going in the right direction before adding some more tests.
If valentin feels comfortable with this I'm happy to delegate it to him
Comment on attachment 800102 [details] [diff] [review]
about_networking_test.patch

Review of attachment 800102 [details] [diff] [review]:
-----------------------------------------------------------------

It looks pretty good so it gets my r+
Attachment #800102 - Flags: review+
(Assignee)

Comment 7

5 years ago
Created attachment 802928 [details] [diff] [review]
about_networking_test.patch

r=valentin.gosu
Attachment #800102 - Attachment is obsolete: true
Attachment #800102 - Flags: review?(jduell.mcbugs)
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Blocks: 915090
https://hg.mozilla.org/integration/fx-team/rev/2a18454f0aa3
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2a18454f0aa3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.