912192 - cppunit tests scheduling changes

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

We should stop scheduling the fedora jobs :-)

https://tbpl.mozilla.org/?tree=Cedar&showall=1&jobname=cpp

Comment 1

[Dan Minor [:dminor]]

Ed, should we be doing these for release builds?

Comment 2

[Ed Morley [:emorley]]

(In reply to Dan Minor [:dminor] from comment #1)
> Ed, should we be doing these for release builds?

Define release?

There are no cppunit tests being scheduled on https://tbpl.mozilla.org/?tree=Mozilla-Release&showall=1&jobname=cpp

Normally when introducing a new test suite, we let it propagate through the various release branches {aurora, beta, release} on the usual 6 week cadence.

Comment 3

[Dan Minor [:dminor]]

Sorry, by release I meant 'opt' builds.

If things continue to look green, I think we should expand these beyond Cedar soon. These tests run now as part of make check, so I don't expect them to give too much trouble.

Comment 4

[Ed Morley [:emorley]]

(In reply to Dan Minor [:dminor] from comment #3)
> Sorry, by release I meant 'opt' builds.
> 
> If things continue to look green, I think we should expand these beyond
> Cedar soon. These tests run now as part of make check, so I don't expect
> them to give too much trouble.

Ah I see (the 'opt' builds aren't actually what we release, 'pgo' is closer, 'nightly' closer still, but not 100%... but that's another mini rant! :-)).

I'm not sure -- ted, should the cppunit tests be run on opt builds too?

Comment 5

[(not currently active) Ted Mielczarek]

We should be running them on all of opt, debug and pgo. They currently get run during the "make check" portion of builds, but we should turn that off when we're satisfied with the standalone job (before we turn them on on m-c and related branches, presumably).

Comment 6

[(not currently active) Ted Mielczarek]

(But comment 0 is correct in that we don't need to be running them on Fedora, just Ubuntu.)

Comment 7

[Ed Morley [:emorley]]

Thanks Ted! :-)

New summary of desired changes:
* Stop scheduling cppunit tests on fedora (we just want ubuntu).
* Also schedule them on opt/pgo, since they're currently only switched on for debug.

Comment 8

[Kim Moir [:kmoir] ET]

I can look at this after testing my changes in bug 912997 for adding jit tests.

Comment 9

[Kim Moir [:kmoir] ET]

Attachment: bug912192.patch

Comment 10

[Kim Moir [:kmoir] ET]

In production

Comment 11

[Kim Moir [:kmoir] ET]

Reopening because changes in bug 892569 had to be reverted.

Comment 12

[Kim Moir [:kmoir] ET]

oops reopened wrong bug should have been bug 920989