Search engine setup for Firefox (desktop) for Catalan

RESOLVED FIXED

Status

Mozilla Localizations
ca / Catalan
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Eduard Gamonal, Assigned: Eduard Gamonal)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 799077 [details] [diff] [review]
Patch to update the search plugins

The search engine list needs to be updated.

The patch removes Llibres.cat (it doesn't work any more with opensearch) and Huubs (already removed in mobile #885079), and adds Twitter.
(Assignee)

Updated

5 years ago
Keywords: productization
(Assignee)

Updated

5 years ago
Attachment #799077 - Flags: review?(milos)
Attachment #799077 - Flags: review?(francesco.lodolo)
Comment on attachment 799077 [details] [diff] [review]
Patch to update the search plugins

Review of attachment 799077 [details] [diff] [review]:
-----------------------------------------------------------------

Patch tested, looks good to me.
Attachment #799077 - Flags: review?(francesco.lodolo) → review+
(Assignee)

Comment 2

5 years ago
Hi,
Can I do anything to help you?
It'd be very nice to have this ready for the next version. Users of the llibres.cat searchplugin get 404 errors.
Comment on attachment 799077 [details] [diff] [review]
Patch to update the search plugins

Pike, do you have time to check this change (moving original r? to milos to f? to you)?
Attachment #799077 - Flags: review?(milos)
Attachment #799077 - Flags: review?
Attachment #799077 - Flags: feedback?(l10n)

Comment 4

5 years ago
Comment on attachment 799077 [details] [diff] [review]
Patch to update the search plugins

Review of attachment 799077 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, too. Please land with a check-in comment referencing this bug and the reviews.

too bad that both sites just broke :-(
Attachment #799077 - Flags: feedback?(l10n) → feedback+
(Assignee)

Comment 5

5 years ago
Hey, this has had no activity for three weeks but we can still make it for the next cycle.
How can we do it?
Eduard, the patch is reviewed so you just need to check it in with a comment like "Bug 912199 - Search engine setup for Firefox (desktop) for Catalan, r=pike, flod".

If you prefer I can do it for you.
(Assignee)

Comment 7

5 years ago
ah I thought you preferred that we don't do that. it's okay for me,I'll apply it, push it and mark this as resolved after the summit.
thanks!
It's important you don't make changes without review, but once the patch is reviewed you can commit it, just reference bug+reviews to make l10n-drivers' work easier when checking sign-offs.

When you commit please put a link to the changeset in the bug too.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.