Closed Bug 912240 Opened 8 years ago Closed 8 years ago
Restore access key for the Clear button in console
See bug 892289 for more info.
Also, the accesskey for Logging should be restored too.
We did not prioritize this bug. Are the tracking flags meant to prioritize this bug for their respective firefox versions?
(In reply to Mihai Sucan [:msucan] from comment #2) > We did not prioritize this bug. Are the tracking flags meant to prioritize > this bug for their respective firefox versions? It appeared to me that this is a user-affecting change that would have a lot of impact to our release audience and that even just a backout might be necessary. If you believe otherwise please let us know.
In my opinion a backout should not be needed. Users can still clear the output using Ctrl-L and Ctrl-K. Anton, you are assigned to this bug. Can you please submit a patch? Or should I do so?
Can the accesskey for Logging be restored too ? (L is free on all platforms to be an accesskey)
Comment on attachment 812899 [details] [diff] [review] Restore accesskey from bug 892289 This is the same accesskey as for the Logging filter button.
Anton: As Girish points out, the accesskey "L" should work for "Logging". With what did it conflict in bug 892289?
Comment on attachment 813343 [details] [diff] [review] Restore accesskeys from bug 892289 thanks
Attachment #813343 - Flags: review?(mihai.sucan) → review+
Updated Anton's patch to include the removal of Cmd-K for clear output. Try push: https://tbpl.mozilla.org/?tree=Try&rev=217ee84fa6ba If this is green, I will land this patch tomorrow.
lsblakk and Dão: I can make a patch for Aurora, but it means string changes. This does not seem to be a severe bug to warrant string changes in that branch - afaik, they are strongly discouraged. Thus, I have set status-firefox26 to wontfix. Users on Aurora can tab to the Clear button and they can also use Ctrl-L and Cmd-K to clear the output. If you disagree, please let me know. Thank you!
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:27.0) Gecko/20100101 Firefox/27.0 Verified as fixed on latest Aurora 27.0a2 (buildID: 20131106004000).
You need to log in before you can comment on or make changes to this bug.