Closed
Bug 912241
Opened 12 years ago
Closed 12 years ago
Move webmaker-events into main repo
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kate, Assigned: kate)
References
Details
Attachments
(1 file)
Let's merge it in so we can do further work on it.
Assignee | ||
Comment 1•12 years ago
|
||
Suggestions on how to make this smaller are welcome.
The size of this can be massively reduced if we use bower for all the front end libs, but i feel like that should be a separate patch.
Attachment #799139 -
Flags: review?(schranz.m)
Updated•12 years ago
|
Assignee: nobody → kate
Status: NEW → ASSIGNED
Comment 2•12 years ago
|
||
Comment on attachment 799139 [details] [review]
https://github.com/mozilla/webmaker.org/pull/347
We can make this smaller in my mind. Getting it to the same current working state is priority number one.
Comments in the PR.
Attachment #799139 -
Flags: review?(schranz.m) → review-
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 799139 [details] [review]
https://github.com/mozilla/webmaker.org/pull/347
Typo and alpha sorting fixed
Attachment #799139 -
Flags: review- → review?(schranz.m)
Comment 4•12 years ago
|
||
Comment on attachment 799139 [details] [review]
https://github.com/mozilla/webmaker.org/pull/347
I've tested the events section with sqlite and mysql and all the basic interactions seem to be working A OKAY. Let's get this in so we can tackle trimming the fat off this gigantic beast.
Attachment #799139 -
Flags: review?(schranz.m) → review+
Comment 5•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/c9951521b5fb9113b3e46cbbb87125bc60b22f81
bug 912241 - Merge webmaker-events into repo.
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•