Closed Bug 912259 Opened 6 years ago Closed 6 years ago

about:networking DNS Lookup Diagnostic Tool - patch over backend

Categories

(Core :: Networking, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: catalinn.iordache, Assigned: catalinn.iordache)

References

Details

Attachments

(1 file, 2 obsolete files)

After creating the proxy settings diag tool patch, I've decided that there were some changes which were needed to be made over dns tool also.

Also, in order to continue the thread safe patch, I want this one to be accepted in Mozilla Core code base.
Attached patch DNSLookupToolBackendpatch.patch (obsolete) — Splinter Review
Assignee: nobody → catalinn.iordache
Attachment #799134 - Flags: review?(mcmanus)
Duplicate of this bug: 912258
Comment on attachment 799134 [details] [diff] [review]
DNSLookupToolBackendpatch.patch

Review of attachment 799134 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/NetDashboard.webidl
@@ -58,5 @@
>  
>  dictionary ConnStatusDict {
>    DOMString status;
>  };
> -

let's not patch the file if all you are doing is changing whitespace

::: netwerk/base/public/nsIDashboard.idl
@@ -46,5 @@
>  
>      /* When true, the service will log websocket events */
>      attribute boolean enableLogging;
>  
> -    /* DNS resolver for host name

let's not patch the file if all you are doing is changing whitespace

::: netwerk/base/src/Dashboard.cpp
@@ +476,5 @@
> +Dashboard::RequestDNSLookup(const nsACString &aHost, NetDashboardCallback *cb)
> +{
> +    if (mDnsup.cb)
> +        return NS_ERROR_FAILURE;
> +    mDnsup.cb = nullptr;

you know its already null (you just checked) - you don't need this assignment
Attachment #799134 - Flags: review?(mcmanus) → review+
Made changes that were specified in review.
Ready for checkin
Attachment #799134 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #799527 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e56e7c0e83f2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.