912279 - Collection objects should return slugs instead of IDs for cat/region/carrier

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Matt Basta [:basta]]

Since we filter on slug only and return ID only, it's a royal PITA to make sure we use slugs in some places and IDs in others. Can we choose one?

Comment 1

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/1082 (bug 911382) will allow you to filter on ids in addition to slugs. We could still return slugs if you prefer though.

Comment 2

[Matt Basta [:basta]]

There's only a few places left that we use IDs, so I'd rather just get rid of those places than convert everything back from slugs. Slugs make for nicer URLs, as well.

Comment 3

[Mathieu Pillard [:mat]]

Ok, I'll take a stab at this.

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/e2e71c7579fc1ef0f32de896c0c2d6b7f453fcdf

Since this is a backwards-incompatible change, someone will need to update rocketfuel to fix the resulting temporary breakage, this is bug 913003

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Guys, this breaking change could have resulted in service our breakage (everything.me).
Luckily we previewed the dump in a local computer and witnessed the breakage before the production update.

We need to be notified on every breaking change. What do we need to do to make this happen?

Btw, the api documentation doesn't reflect the change either.

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Typo in first line: ...breakage in our service

Comment 7

[Chuck Harmston [:chuck]]

Ran: are you using a rocketfuel API endpoint? Those endpoints are designed specifically for consumption by a tool of ours and aren't guaranteed to be stable, per the note at the top of the page in the docs here:

http://firefox-marketplace-api.readthedocs.org/en/latest/topics/rocketfuel.html

If this fix broke something outside of those endpoints, would you mind filing a bug about it? That would be a pretty high-priority problem.

Thanks!

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Hey Chuck, no we're using the official v1 api.

Here's an example of the change on production. I'll open a bug.
https://marketplace.firefox.com/api/v1/apps/app/twitter/?format=JSON

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Created Bug 932365

Comment 10

[Wil Clouser [:clouserw]]

(In reply to Ran Ben Aharon (Everything.me) from comment #9)
> Created Bug 932365

Thanks Ran.  Sounds like this affected more APIs than planned for.