912352 - Windows OMTC window resizing - part two

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nick Cameron [:nrc]]

Following up bug 899435. Those fixes seem necessary but not sufficient - they make things better but not perfect. In particular, resizing with the top or left sides is still not smooth.

Comment 1

[Nick Cameron [:nrc]]

The problem is that when we resize, Windows does not repaint the window at the new location (when resize from the top or left we are kind of moving the window as well as resizing it). So either the window has a big white patch or it is inappropriately clipped.

The reason seems to be that when we resize we reflow then invalidate the window with Windows which gets us a WM_PAINT and then we repaint the entire window and then do a transaction causing us to composite. And while that happens, we just have the old pixels on screen. The solution (I think) is to do an async composite as soon as we get the WM_PAINT message then start repainting.

New texture space is black rather white too. We should probably change that.

Comment 2

[Nick Cameron [:nrc]]

Attachment: composite asap on WM_PAINT

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 799296 [details] [diff] [review]
composite asap on WM_PAINT

Review of attachment 799296 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 4

[Nick Cameron [:nrc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/feb179160273

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/feb179160273