912368 - config/tests/src-simple doesn't test how jar.mn are actually treated

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

All directories where there are locale jar.mn define relativesrcdir, and that makefile doesn't. Setting relativesrcdir does change how jarmaker is invoked.
But setting it makes config.mk set LOCALE_SRCDIR, while that makefile wants a specific value. So we also need to allow a LOCALE_SRCDIR override.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Set relativesrcdir in config/tests/src-simple/Makefile and adjust so that it works

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 799323 [details] [diff] [review]
Set relativesrcdir in config/tests/src-simple/Makefile and adjust so that it works

Review of attachment 799323 [details] [diff] [review]:
-----------------------------------------------------------------

I don't quite follow what's wrong, but the change looks innocent enough.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/595ef28d3cf1

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/595ef28d3cf1