Closed Bug 912368 Opened 6 years ago Closed 6 years ago

config/tests/src-simple doesn't test how jar.mn are actually treated

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

All directories where there are locale jar.mn define relativesrcdir, and that makefile doesn't. Setting relativesrcdir does change how jarmaker is invoked.
But setting it makes config.mk set LOCALE_SRCDIR, while that makefile wants a specific value. So we also need to allow a LOCALE_SRCDIR override.
Blocks: 912293
Comment on attachment 799323 [details] [diff] [review]
Set relativesrcdir in config/tests/src-simple/Makefile and adjust so that it works

Review of attachment 799323 [details] [diff] [review]:
-----------------------------------------------------------------

I don't quite follow what's wrong, but the change looks innocent enough.
Attachment #799323 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/595ef28d3cf1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.