912508 - Implement the "X has left the conference call" banner

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Etienne Segonzac (:etienne)]

What needs to happen:

* We need to implement a |requestBanner(message)| method on the CallScreen (with tests ;))

* Detect that a call from the conference group was disconnected (|this.call.group| will be truthy)

* |Call CallScreen.requestBanner(message)| when this happen

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Banner on the call screen

Comment 2

[Etienne Segonzac (:etienne)]

Attachment: Banner on the details screen

Comment 3

[Etienne Segonzac (:etienne)]

German, do you feel like taking this one?

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Absolutely, no problem about taking it :-) Anyhow, I sent an email to you with some questions to see if I have the guts to solve it :-p I did not feel confident enough to publicly include those questions as comments here. I will once I have your answers ;-)

Comment 5

[Fernando Campo (:fcampo)]

I'm temporarily stealing it per request, to work faster with Etienne during Oslo working week

Comment 6

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/12113

Wonder if we need the late-l10n tag as we add a new string for the banner

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 802924 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/12113

Comments on github.

I think using the CallScreen would be much better and much more testable :)

Comment 8

[Etienne Segonzac (:etienne)]

Almost there!

* we need to remove the lazy loading of already loaded stuffs
* still some work on the tests, comments are on github but ping me if you want any help with sinon.clock

Comment 9

[Fernando Campo (:fcampo)]

Comment on attachment 802924 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/12113

PR updated, asking for review again

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 802924 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/12113

Made bunch of small comments on github.
We're close.

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 802924 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/12113

All good, thanks for the hard work!

Comment 12

[Fernando Campo (:fcampo)]

\o/ 

merged at master: 937b3aff11b224981f8a14149aa6f3265296ad8b