912541 - Make the performance test work again

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Julien Wajsberg [:julienw]]

Currenrly the performance test are broken, probably because of the new XULRunner.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

see also github PR at https://github.com/mozilla-b2g/gaia/pull/11927

So I'm modifying the marionette.js file, but I don't know if we have a new one that would work somewhere.

The main problem, besides the bool pref, is that we use Object.create on a native object, and it looks like Gecko doesn't like this.

The dirty hack (thanks to :ochameau) is to set the real native socket object on the object we create, and call "send" on it. I'd very much prefer to have a real wrapper around the native object instead of using Object.create, but, well, this does the job.

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 799544 [details] [diff] [review]
patch v1

Sorry, it's not ready yet. It's running but there is an error in the reporter then.

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: wip patch v2

There are still weird things happening:
* a line is printed whereas it should not : { '0': {} }
I don't have a clue of where it comes from.
* deleteSession seems to timeout

Comment 4

[Julien Wajsberg [:julienw]]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Created attachment 799592 [details] [diff] [review]
> wip patch v2
> 
> There are still weird things happening:
> * a line is printed whereas it should not : { '0': {} }
> I don't have a clue of where it comes from.
> * deleteSession seems to timeout

These 2 things are related:
"{ '0': {} }" is actually an error coming from marionette. The marionette client just outputs it on the console.

Comment 5

[Julien Wajsberg [:julienw]]

It's an error dispatched by TCPSocket. Probably because the socket is closed. I don't know why this is closed before we get the deleteSession answer.

Let's see if we can port the perf test to the new marionette client while we're in Oslo :)

Comment 6

[Julien Wajsberg [:julienw]]

will be done in bug 915156 and bug 915158