Closed Bug 912541 Opened 6 years ago Closed 6 years ago

Make the performance test work again

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: julienw, Assigned: julienw)

References

Details

(Keywords: perf, Whiteboard: [c= p= s=2013.09.20 u=])

Attachments

(1 file, 1 obsolete file)

Currenrly the performance test are broken, probably because of the new XULRunner.
Assignee: nobody → felash
Attached patch patch v1 (obsolete) — Splinter Review
see also github PR at https://github.com/mozilla-b2g/gaia/pull/11927

So I'm modifying the marionette.js file, but I don't know if we have a new one that would work somewhere.

The main problem, besides the bool pref, is that we use Object.create on a native object, and it looks like Gecko doesn't like this.

The dirty hack (thanks to :ochameau) is to set the real native socket object on the object we create, and call "send" on it. I'd very much prefer to have a real wrapper around the native object instead of using Object.create, but, well, this does the job.
Attachment #799544 - Flags: review?(jlal)
Comment on attachment 799544 [details] [diff] [review]
patch v1

Sorry, it's not ready yet. It's running but there is an error in the reporter then.
Attachment #799544 - Flags: review?(jlal)
Blocks: 838657
Keywords: perf
Attached patch wip patch v2Splinter Review
There are still weird things happening:
* a line is printed whereas it should not : { '0': {} }
I don't have a clue of where it comes from.
* deleteSession seems to timeout
Attachment #799544 - Attachment is obsolete: true
(In reply to Julien Wajsberg [:julienw] from comment #3)
> Created attachment 799592 [details] [diff] [review]
> wip patch v2
> 
> There are still weird things happening:
> * a line is printed whereas it should not : { '0': {} }
> I don't have a clue of where it comes from.
> * deleteSession seems to timeout

These 2 things are related:
"{ '0': {} }" is actually an error coming from marionette. The marionette client just outputs it on the console.
It's an error dispatched by TCPSocket. Probably because the socket is closed. I don't know why this is closed before we get the deleteSession answer.

Let's see if we can port the perf test to the new marionette client while we're in Oslo :)
Status: NEW → ASSIGNED
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Whiteboard: [c= p= s= u=]
Blocks: 914910
will be done in bug 915156 and bug 915158
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Whiteboard: [c= p= s= u=] → [c= p= s=2013.09.20 u=]
You need to log in before you can comment on or make changes to this bug.