Closed
Bug 912637
Opened 12 years ago
Closed 9 years ago
please remove http.py from tools/.../builddb as it is not used
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: vciobancai)
References
Details
Attachments
(1 file)
|
23.90 KB,
patch
|
jmaher
:
review+
vciobancai
:
checked-in+
|
Details | Diff | Splinter Review |
an old script from a long time ago:
http://hg.mozilla.org/build/tools/file/8024c7811470/buildfarm/utils/generator/places/builddb/http.py
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → vlad.ciobancai
|
|
Assignee | |
Comment 1•9 years ago
|
||
After some research about the following python script http.py from what I see the function defined "get_web_data" is used in http://hg.mozilla.org/build/tools/file/tip/buildfarm/utils/generator/places/builddb/generate.py#l704
Do you want us to remove it also from generate.py ?
Flags: needinfo?(jmaher)
|
Reporter | |
Comment 2•9 years ago
|
||
we don't need generate.py anymore as well- we haven't used the generated places.sqlite, etc. for over a year.
Flags: needinfo?(jmaher)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attached the patch wich removed the files(generate.py and http.py)
Attachment #8741700 -
Flags: review?(jmaher)
|
|
Reporter | |
Comment 4•9 years ago
|
||
Comment on attachment 8741700 [details] [diff] [review]
Bug_912637_remove_http.py.patch
Review of attachment 8741700 [details] [diff] [review]:
-----------------------------------------------------------------
thanks for removing this unused code.
Attachment #8741700 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8741700 -
Flags: checked-in+
|
|
Assignee | |
Comment 5•9 years ago
|
||
The patch has been landed in default branch
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Component: Tools → General
You need to log in
before you can comment on or make changes to this bug.
Description
•