Closed Bug 912747 Opened 10 years ago Closed 10 years ago

Change nsCycleCollectionHoldDrop.h to mozilla/HoldDropJSObjects.h

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

rename it
8.18 KB, patch
khuey
: review+
Details | Diff | Splinter Review 
Both khuey and Ms2ger have complained about the olde world charm of nsCycleCollectionDropHold.h, so it should get moved to something like mozilla/CycleCollectionDropHold.h or mozilla/DropHold.h
Maybe HoldDrop would be better, as you hold before you drop.
Assignee: nobody → continuation
Summary: Change nsCycleCollectionDropHold.h to mozilla/DropHold.h or something → Change nsCycleCollectionHoldDrop.h to mozilla/HoldDrop.h or something
Summary: Change nsCycleCollectionHoldDrop.h to mozilla/HoldDrop.h or something → Change nsCycleCollectionHoldDrop.h to mozilla/HoldDropJSObjects.h
Attached patch rename it — — Splinter Review 

        Attachment #801912 -
        Flags: review?(khuey)

    
    

    
  
Comment on attachment 801912 [details] [diff] [review]
rename it

Review of attachment 801912 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/HoldDropJSObjects.h
@@ +4,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef HoldDropJSObjects_h_
> +#define HoldDropJSObjects_h_

nit: mozilla_...

        Attachment #801912 -
        Flags: review?(khuey) → review+

    
    

    
  
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)
> Comment on attachment 801912 [details] [diff] [review]
> rename it
> 
> Review of attachment 801912 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: xpcom/glue/HoldDropJSObjects.h
> @@ +4,5 @@
> >   * License, v. 2.0. If a copy of the MPL was not distributed with this
> >   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> >  
> > +#ifndef HoldDropJSObjects_h_
> > +#define HoldDropJSObjects_h_
> 
> nit: mozilla_...

And nit from the other side: no trailing underscore, please.

    
    

    
  
Thanks, I fixed both of those problems.

https://hg.mozilla.org/integration/mozilla-inbound/rev/69e2cfaac25e

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/69e2cfaac25e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

          You need to log in
          before you can comment on or make changes to this bug.