912747 - Change nsCycleCollectionHoldDrop.h to mozilla/HoldDropJSObjects.h

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

Both khuey and Ms2ger have complained about the olde world charm of nsCycleCollectionDropHold.h, so it should get moved to something like mozilla/CycleCollectionDropHold.h or mozilla/DropHold.h

Comment 1

[Andrew McCreight [:mccr8]]

Maybe HoldDrop would be better, as you hold before you drop.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: rename it

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 801912 [details] [diff] [review]
rename it

Review of attachment 801912 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/glue/HoldDropJSObjects.h
@@ +4,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef HoldDropJSObjects_h_
> +#define HoldDropJSObjects_h_

nit: mozilla_...

Comment 4

[Andrew McCreight [:mccr8]]

try run: https://tbpl.mozilla.org/?tree=Try&rev=760c1d1023c0

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #3)
> Comment on attachment 801912 [details] [diff] [review]
> rename it
> 
> Review of attachment 801912 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: xpcom/glue/HoldDropJSObjects.h
> @@ +4,5 @@
> >   * License, v. 2.0. If a copy of the MPL was not distributed with this
> >   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> >  
> > +#ifndef HoldDropJSObjects_h_
> > +#define HoldDropJSObjects_h_
> 
> nit: mozilla_...

And nit from the other side: no trailing underscore, please.

Comment 6

[Andrew McCreight [:mccr8]]

Thanks, I fixed both of those problems.

https://hg.mozilla.org/integration/mozilla-inbound/rev/69e2cfaac25e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69e2cfaac25e