912809 - scrollIntoView(true) results in a broken test state

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[James Lal [:lightsofapollo]]

I ran into this same problem when working on the "auto focus" forms feature in b2g where scrollIntoView(true) would put the device in a broken scroll state ( will attach an image ). Is there some rational that makes true better then false? If not false works better... Sadly I don't have background why it is this way yet.

Comment 1

[James Lal [:lightsofapollo]]

Attachment: turn scrollIntoView to false

Comment 2

[James Lal [:lightsofapollo]]

Attachment: Screen Shot 2013-09-04 at 5.53.26 PM.png

Image example- this can happen in other cases... I will try to figure out what causes this and hopefully file a bug to either fix this or write a marionette server test to cover the case.

Comment 3

[Jonathan Griffin (:jgriffin)]

Malini or David could likely answer this better than I.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 799901 [details] [diff] [review]
turn scrollIntoView to false

Review of attachment 799901 [details] [diff] [review]:
-----------------------------------------------------------------

Just intuitively, this change makes sense.  I'm going to make a try run and see what happens.

Comment 5

[Jonathan Griffin (:jgriffin)]

https://tbpl.mozilla.org/?tree=Try&rev=94ffde5219c8

Comment 6

[Jonathan Griffin (:jgriffin)]

This patch didn't apply cleanly, which resulted in a no-op try run.  I've fixed that, and pushed to try again:  https://tbpl.mozilla.org/?tree=Try&rev=922e6cb74eb6

Comment 7

[Jonathan Griffin (:jgriffin)]

try run is green, let's ship it!

Comment 8

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cca8f2b78300

Hopefully this won't impact gaia-ui-tests, but cc'ing WebQA in case it does.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cca8f2b78300