Closed Bug 912820 Opened 11 years ago Closed 11 years ago

Make --disable-content-sandbox* work.

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: jld, Assigned: jld)

References

Details

Attachments

(1 file, 1 obsolete file)

Make --disable-content-sandbox* configure flags work. (v2)
1.29 KB, patch
jld
: review+
Details | Diff | Splinter Review 
The m4 for the content process sandboxing doesn't handle the --disable forms of the options correctly.  The fix is simple.
Note: this patch is based on a version containing the patch in bug 912807, and the diff contexts overlap.
Attachment #799916 - Flags: review?(gps)
Comment on attachment 799916 [details] [diff] [review]
Make --disable-content-sandbox* configure flags work.

As I mentioned in bug 912807, we should only enable reporter for ENG builds.

The other change looks good to me.
Attachment #799916 - Flags: review?(gps) → review+
Rebased so it can be applied cleanly.  Carrying over previous r+ from gps.
Attachment #799916 - Attachment is obsolete: true
Attachment #800459 - Flags: review+
Checkin note: This is for all practical purposes a b2g-related change, so I think it should be pushed to b2g-inbound?
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9c34952d655b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: