912876 - Remove the downloads file in common_test_Download.js for test_platform_integration()

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Raymond Lee [:raymondlee]]

In the test_platform_integration(), it uses DownloadIntegration.getSystemDownloadsDirectory() to form the target file path, not the normal temporary directory.  

On Mac, I see the download files created in my /Users/{username}/Downloads/ by the test. it's best to remove those downloads when that test is complete.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[:Paolo Amadini]

Comment on attachment 800022 [details] [diff] [review]
v1

Thanks for fixing this!

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: Patch to checkin

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #3)
> Created attachment 800180 [details] [diff] [review]
> Patch to checkin

Pushed to try and waiting for results.

Comment 5

[Raymond Lee [:raymondlee]]

https://tbpl.mozilla.org/?tree=Try&rev=5995601088cd

Comment 6

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #5)
> https://tbpl.mozilla.org/?tree=Try&rev=5995601088cd

Passed try

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/47293f729adc

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/47293f729adc