Closed Bug 912889 Opened 8 years ago Closed 8 years ago

[app manager] tooltip and help everywhere

Categories

(DevTools Graveyard :: WebIDE, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: paul, Assigned: jryans)

References

Details

Attachments

(1 file, 2 obsolete files)

There's no tooltip in the app manager. And we should also add some help buttons.
Blocks: appmgr_v1
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attached patch Add tooltips and help (obsolete) — Splinter Review
Lots of tooltips and one help button.

I don't like the placement of the help button, so please let me know what you think.  Also, I couldn't think of a good place to put a link to "Using App Manager".  Maybe that can be in Paul's first run info?
Attachment #804120 - Flags: review?(poirot.alex)
Ryan, look at attachment 804402 [details]. I added a "help" button.
Ah cool, I thought that might happen. :)
Comment on attachment 804120 [details] [diff] [review]
Add tooltips and help

Moving to Paul instead for a faster response.
Attachment #804120 - Flags: review?(poirot.alex) → review?(paul)
Attached patch Add tooltips and help (v2) (obsolete) — Splinter Review
Rebased.
Attachment #804120 - Attachment is obsolete: true
Attachment #804120 - Flags: review?(paul)
Attachment #804502 - Flags: review?(paul)
Comment on attachment 804502 [details] [diff] [review]
Add tooltips and help (v2)

Don't use xxxxTitle, but xxxxTooltip.

Localize URLs as well:
https://developer.mozilla.org/docs/Web/Apps/App_permissions

"Open the Developer Tools in a new window connected to this app on the device."
-> remove "in a new window"

"Save the host and port of the device."
-> "Save the host and port" (it's not really "of the device")
Attachment #804502 - Flags: review?(paul) → review-
Addressed all review comments.
Attachment #804502 - Attachment is obsolete: true
Attachment #804529 - Flags: review?(paul)
Attachment #804529 - Flags: review?(paul) → review+
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/0071687b2b2f

FYI, you don't need to put [land-in-fx-team] on the whiteboard anymore.
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0071687b2b2f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.