Closed Bug 912892 Opened 7 years ago Closed 7 years ago

[app manager] simulator launch UI

Categories

(DevTools Graveyard :: WebIDE, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: paul, Assigned: paul)

References

Details

Attachments

(2 files)

We need a simulator store. We also need the UI that would install the simulator if not present.
Blocks: appmgr_v1
Attached patch patch v1Splinter Review
Attachment #802191 - Flags: review?(poirot.alex)
Comment on attachment 802191 [details] [diff] [review]
patch v1

Review of attachment 802191 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works great!

::: browser/app/profile/firefox.js
@@ +1067,5 @@
>  pref("devtools.commands.dir", "");
>  
>  // Disable the app manager
>  pref("devtools.appmanager.enabled", false);
> +pref("devtools.appmanager.simulatorInstallPage", "https://addons.mozilla.org/firefox/addon/firefox-os-simulator/");

I'm pretty confident we are going to create a new addon on AMO distinct from the existing one, but let's change this pref whenever we publish this new addon on AMO.

::: browser/devtools/app-manager/content/connection-footer.js
@@ +138,5 @@
> +          this.connection.keepConnecting = false;
> +        });
> +        this.connection.keepConnecting = true;
> +        this.connection.connect();
> +      }); 

trailing space

::: browser/devtools/app-manager/content/connection-footer.xhtml
@@ +114,5 @@
> +  <template id="simulator-item-template">
> +  <span>
> +    <button class="simulator-item" onclick="UI.startSimulator(this.dataset.version)" template='{"type":"attribute","path":"version","name":"data-version"}'>
> +      <span template='{"type":"textContent", "path":"version"}'></span>
> +    </button>

It feels weird to click on this button and nothing happen. The simulator is launched, but everything stay as-is in the connection footer. I'm wondering if we should dismiss the simulator list and display the regular connection footer with the disconnect button, or change the button state of the selected simulator.

In any case, we can improve this in a followup.

::: browser/locales/en-US/chrome/browser/devtools/app-manager.dtd
@@ +33,5 @@
>  <!ENTITY connection.cancel "Cancel">
>  <!ENTITY connection.or "or">
> +<!ENTITY connection.noSimulatorInstalled "No simulator installed.">
> +<!ENTITY connection.installFirstSimulator "Install simulator.">
> +<!ENTITY connection.installAnotherSimulator "Add">

What about using Install instead of Add?
Attachment #802191 - Flags: review?(poirot.alex) → review+
I pushed a new version of my branch against the simulator:
  https://github.com/mozilla/r2d2b2g/pull/756

This allows to build simulator addons that works with the app manager!
(In reply to Alexandre Poirot (:ochameau) from comment #2)
> ::: browser/devtools/app-manager/content/connection-footer.xhtml
> @@ +114,5 @@
> > +  <template id="simulator-item-template">
> > +  <span>
> > +    <button class="simulator-item" onclick="UI.startSimulator(this.dataset.version)" template='{"type":"attribute","path":"version","name":"data-version"}'>
> > +      <span template='{"type":"textContent", "path":"version"}'></span>
> > +    </button>
> 
> It feels weird to click on this button and nothing happen. The simulator is
> launched, but everything stay as-is in the connection footer. I'm wondering
> if we should dismiss the simulator list and display the regular connection
> footer with the disconnect button, or change the button state of the
> selected simulator.

Oh yeah, I forgot that. I'll just dismiss the simulator list.
This might look weird during the launch -> connection period, but I'll address that later.

> > +<!ENTITY connection.installAnotherSimulator "Add">
> 
> What about using Install instead of Add?

I want a short button, and to be clear that it's not needed to install something else.
Attached patch patch to landSplinter Review
Depends on: 914110
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d9b79f9842c1
Assignee: nobody → paul
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.