912980 - Don't use VPATH in content/media/webspeech/recognition

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Bug 912862 is removing the reference to that file from content/media/webspeech/recognition/test/moz.build because:
- it isn't built because there's no library or program generated in that directory.
- when explicitely built, it fails to build because of a wrong include (missing a mozilla/dom path or something)

Either it should be fixed, and built usefully, or removed from the tree.

Comment 1

[Guilherme Gonçalves [:ggp]]

This file is used by the speech recognition tests under content/media/webspeech/recognition/test/, so it is not really unused. As for it not being built, that's not what I observe here: it does get built and used when I run these tests locally.

Comment 2

[Mike Hommey [:glandium]]

Oh great. It's built from content/media/webspeech/recognition... with a VPATH. So I'll turn this bug into fixing that.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Don't use VPATH in content/media/webspeech/recognition

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 800416 [details] [diff] [review]
Don't use VPATH in content/media/webspeech/recognition

Review of attachment 800416 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webspeech/recognition/moz.build
@@ +26,5 @@
>  ]
>  
>  CPP_SOURCES += [
>      'EnableWebSpeechRecognitionCheck.cpp',
> +    'test/FakeSpeechRecognitionService.cpp',

doesn't this break strict ordering requirements?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #4)
> Comment on attachment 800416 [details] [diff] [review]
> Don't use VPATH in content/media/webspeech/recognition
> 
> Review of attachment 800416 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/media/webspeech/recognition/moz.build
> @@ +26,5 @@
> >  ]
> >  
> >  CPP_SOURCES += [
> >      'EnableWebSpeechRecognitionCheck.cpp',
> > +    'test/FakeSpeechRecognitionService.cpp',
> 
> doesn't this break strict ordering requirements?

Surprisingly, no. Maybe there's no strict ordering requirement on CPP_SOURCES?

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e078b4d207f6

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Mike Hommey [:glandium] from comment #5)
> (In reply to Gregory Szorc [:gps] from comment #4)
> > Comment on attachment 800416 [details] [diff] [review]
> > Don't use VPATH in content/media/webspeech/recognition
> > 
> > Review of attachment 800416 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: content/media/webspeech/recognition/moz.build
> > @@ +26,5 @@
> > >  ]
> > >  
> > >  CPP_SOURCES += [
> > >      'EnableWebSpeechRecognitionCheck.cpp',
> > > +    'test/FakeSpeechRecognitionService.cpp',
> > 
> > doesn't this break strict ordering requirements?
> 
> Surprisingly, no. Maybe there's no strict ordering requirement on
> CPP_SOURCES?

Indeed.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e078b4d207f6