Closed
Bug 912980
Opened 11 years ago
Closed 11 years ago
Don't use VPATH in content/media/webspeech/recognition
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
1.73 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Bug 912862 is removing the reference to that file from content/media/webspeech/recognition/test/moz.build because:
- it isn't built because there's no library or program generated in that directory.
- when explicitely built, it fails to build because of a wrong include (missing a mozilla/dom path or something)
Either it should be fixed, and built usefully, or removed from the tree.
|
||
Updated•11 years ago
|
Component: Web Audio → Video/Audio
|
||
Comment 1•11 years ago
|
||
This file is used by the speech recognition tests under content/media/webspeech/recognition/test/, so it is not really unused. As for it not being built, that's not what I observe here: it does get built and used when I run these tests locally.
|
Assignee | |
Comment 2•11 years ago
|
||
Oh great. It's built from content/media/webspeech/recognition... with a VPATH. So I'll turn this bug into fixing that.
Component: Video/Audio → Build Config
Summary: Figure what to do about FakeSpeechRecognitionService.cpp → Don't use VPATH in content/media/webspeech/recognition
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #800416 -
Flags: review?(gps)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
|
||
Comment 4•11 years ago
|
||
Comment on attachment 800416 [details] [diff] [review]
Don't use VPATH in content/media/webspeech/recognition
Review of attachment 800416 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/media/webspeech/recognition/moz.build
@@ +26,5 @@
> ]
>
> CPP_SOURCES += [
> 'EnableWebSpeechRecognitionCheck.cpp',
> + 'test/FakeSpeechRecognitionService.cpp',
doesn't this break strict ordering requirements?
Attachment #800416 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #4)
> Comment on attachment 800416 [details] [diff] [review]
> Don't use VPATH in content/media/webspeech/recognition
>
> Review of attachment 800416 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: content/media/webspeech/recognition/moz.build
> @@ +26,5 @@
> > ]
> >
> > CPP_SOURCES += [
> > 'EnableWebSpeechRecognitionCheck.cpp',
> > + 'test/FakeSpeechRecognitionService.cpp',
>
> doesn't this break strict ordering requirements?
Surprisingly, no. Maybe there's no strict ordering requirement on CPP_SOURCES?
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
||
Comment 7•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #5)
> (In reply to Gregory Szorc [:gps] from comment #4)
> > Comment on attachment 800416 [details] [diff] [review]
> > Don't use VPATH in content/media/webspeech/recognition
> >
> > Review of attachment 800416 [details] [diff] [review]:
> > -----------------------------------------------------------------
> >
> > ::: content/media/webspeech/recognition/moz.build
> > @@ +26,5 @@
> > > ]
> > >
> > > CPP_SOURCES += [
> > > 'EnableWebSpeechRecognitionCheck.cpp',
> > > + 'test/FakeSpeechRecognitionService.cpp',
> >
> > doesn't this break strict ordering requirements?
>
> Surprisingly, no. Maybe there's no strict ordering requirement on
> CPP_SOURCES?
Indeed.
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•