913014 - Nodes in the inspector's computed style view are hard to expand collapse.

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

Bug 855523 was used to re-work the markup view in a way that nodes would be easily expanded and collapsed.

This bug should bring the same to the computed styles view.

This view has no edition capabilities, so the expand/collapse functionality can easily be expanded to the whole row instead of being limited to the twisty icon.

Comment 1

[Patrick Brosset <:pbro>]

In order to work like the markup view does, I propose to keep the single click toggling on the twisty icon, and add a double click toggling on the rest of the style container.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: 913014-computed-view-toggle.patch

Work in progress.
Missing a test for the dblclick, which I can't get to work.
Heather, would you mind taking a look and let me know what I'm doing wrong with the EventUtils lib?
Thanks.

Comment 3

[Patrick Brosset <:pbro>]

Attachment: 913014-computed-view-toggle.patch

I managed to make the double click test working.
So attaching a new patch, rebased, ready for review.

Comment 4

[Heather Arthur [:harth]]

Patrick, I'm trying out this patch, and clicking the row doesn't seem to expand it. Is that functionality in this patch?

Comment 5

[Patrick Brosset <:pbro>]

See comment 1, this bug aims at bringing the same level of functionality as the markup view does, that is:
- single click on twisty
- double click on the container itself.
So you should try to double click instead.
Cheers

Comment 6

[Heather Arthur [:harth]]

Comment on attachment 802261 [details] [diff] [review]
913014-computed-view-toggle.patch

Review of attachment 802261 [details] [diff] [review]:
-----------------------------------------------------------------

Aha, sorry. This looks good, thanks!

Comment 7

[Patrick Brosset <:pbro>]

Thanks Heather for the review.
This patch is a week old and will need some merging with bug 835808 when it lands, so I'll hold it for now and rebase/merge and re-attach the patch when done.

Comment 8

[Patrick Brosset <:pbro>]

Attachment: bug913014-computed-view-toggle.patch

Attaching a new version of the patch:
- Merged with 835808 that landed in fx-team a couple of days ago.
- Rebased with the latest fx-team.

Comment 9

[Patrick Brosset <:pbro>]

Pushed to TRY once more for good measure: https://tbpl.mozilla.org/?tree=Try&rev=9c161d2b7891

Comment 10

[Patrick Brosset <:pbro>]

TRY all green!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/4947135aebac

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4947135aebac